Log for DPL calls#4140
Merged
maliberty merged 4 commits intoThe-OpenROAD-Project:masterfrom Apr 14, 2026
Merged
Conversation
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the OpenROAD subproject and integrates logging wrappers for detailed placement across several TCL scripts, while also adding placement verification in the global routing flow. However, the changes in flow/scripts/cts.tcl introduce a typo, using the undefined command logc_cmd instead of log_cmd, which will cause the script to fail.
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Member
|
This PR reset OR to an older version. There is no need to update it in this PR at all. |
Contributor
Whops! I didn't mean to do that. |
maliberty
approved these changes
Apr 14, 2026
Contributor
|
the error on the secure-CI is only with swerv_wrapper, which has been showing non-determinism with yosys |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
include log_cmd to DPL calls and include check placement to GRT script.