WDT32: Add reset to wden_p to fix WDOV X-propagation after reset#4142
WDT32: Add reset to wden_p to fix WDOV X-propagation after reset#4142ashnaaseth2325-oss wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds an asynchronous reset to the wden_p register in the WDT32 module to resolve X-propagation issues during simulation. While the change is correct, feedback suggests that a duplicate version of this IP module exists in another directory and should also be updated to ensure consistency across the repository.
| always @(posedge clk or posedge rst) | ||
| if (rst) wden_p <= 1'b0; | ||
| else wden_p <= WDEN; |
There was a problem hiding this comment.
The addition of the asynchronous reset to wden_p correctly addresses the X-propagation issue during simulation. However, the same IP module is duplicated at flow/designs/src/chameleon_hier/rtl/IPs/WDT32.v and remains unpatched in this pull request. To ensure consistency across the repository and prevent simulation/synthesis mismatches in designs using the hierarchical path, this fix should be applied to that file as well.
0738cc8 to
ddea65c
Compare
|
Hello @maliberty , |
wden_p lacked an async reset, causing a simulation/synthesis mismatch: WDOV could be driven X in simulation immediately after reset deassertion when WDEN is asserted. Signed-off-by: Ashnaa Seth <ashnaaseth2325@gmail.com> Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
Signed-off-by: Ashnaa Seth <ashnaaseth2325@gmail.com> Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
ddea65c to
d2f1f41
Compare
1. SUMMARY
This PR fixes a reset inconsistency in the
wden_pregister within the WDT32 module that leads to simulation/synthesis mismatch during startup. The issue affects how theWDOVsignal is computed immediately after reset due to an uninitialized register.Primary changes are in
flow/designs/src/chameleon/IPs/WDT32.vwithin the WDT32 module.2. FIX
3. VERIFICATION
Simulated reset sequence with
WDEN=1asserted during reset and observedWDOVbehavior after deassertion. The signal no longer transitions toXand remains stable at0until valid conditions are met. Behavior now matches synthesis, eliminating mismatch and X-propagation.