odb: Add support for LEF58_MUSTJOINALLPORTS#10060
Open
QuantamHD wants to merge 5 commits intoThe-OpenROAD-Project:masterfrom
Open
odb: Add support for LEF58_MUSTJOINALLPORTS#10060QuantamHD wants to merge 5 commits intoThe-OpenROAD-Project:masterfrom
QuantamHD wants to merge 5 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Adds support for parsing this property.
Returns true if all shapes of this terminal must be connected electrically.
For example if there's two shapes that make up the 'A' terminal, they must
both be connected to the net that drives A.
```
Without MUSTJOINALLPORTS (Default behavior):
--------------------------------------------
Connecting to ANY shape of ANY port is sufficient to connect to the PIN.
+------------------------------------------+
| PIN A |
| |
| +----------------+ +----------------+ |
| | PORT 1 | | PORT 2 | |
| | +---------+ | | +---------+ | |
| | | Shape 1 | | | | Shape 3 | | |
| | +---------+ | | +---------+ | |
| | OR | | | |
| | +---------+ | | | |
| | | Shape 2 | | | | |
| | +---------+ | | | |
| +----------------+ +----------------+ |
+------------------------------------------+
| |
+----------OR---------+
|
v
Router connects to ANY ONE
of {Shape 1, Shape 2, Shape 3}
With MUSTJOINALLPORTS:
----------------------
The router MUST connect to AT LEAST ONE shape of EACH port.
Ports are treated as independent connection requirements.
+------------------------------------------+
| PIN A (MUSTJOINALLPORTS) |
| |
| +----------------+ +----------------+
| | PORT 1 | | PORT 2 |
| | +---------+ | | +---------+ |
| | | Shape 1 | | | | Shape 3 | |
| | +---------+ | | +---------+ |
| | OR | | |
| | +---------+ | | |
| | | Shape 2 | | | |
| | +---------+ | | |
| +--------|-------+ +--------|-------+
+-----------|-----------------------|------+
| |
v v
MUST CONNECT TO MUST CONNECT TO
(Shape 1 OR Shape 2) AND (Shape 3)
```
Signed-off-by: Ethan Mahintorabi <ethanmoon@google.com>
Signed-off-by: Ethan Mahintorabi <ethanmoon@google.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for the LEF58_MUSTJOINALLPORTS property within the dbMTerm class, encompassing database schema updates, flag management, and LEF file parsing. The review feedback suggests improving the robustness of the property parsing logic in lefin.cpp to avoid false positives, clarifying the API documentation regarding port connection requirements, and simplifying redundant boolean comparisons in the getter implementation.
Signed-off-by: Ethan Mahintorabi <ethanmoon@google.com>
Signed-off-by: Ethan Mahintorabi <ethanmoon@google.com>
Signed-off-by: Ethan Mahintorabi <ethanmoon@google.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
Author
|
@maliberty It looks like both of the failing tests are flakes. How would you like me to proceed? |
gadfort
reviewed
Apr 8, 2026
| inline constexpr uint32_t kSchemaInitial = 57; | ||
|
|
||
| inline constexpr uint32_t kSchemaMinor = 128; // Current revision number | ||
| inline constexpr uint32_t kSchemaMinor = 130; // Current revision number |
Collaborator
There was a problem hiding this comment.
should be kSchemaMinor = 129;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for parsing LEF58_MUSTJOINALLPORTS.
Returns true if all shapes of this terminal must be connected electrically. For example if there's two shapes that make up the 'A' terminal, they must both be connected to the net that drives A.
Type of Change
Impact
No behavior change just odb change
Verification
./etc/Build.sh).