Allow the openSTA submodule to see the readline initialization.#10070
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Apr 7, 2026
Merged
Conversation
Thus, it can use it as prepared in The-OpenROAD-Project/OpenSTA#341 Signed-off-by: Henner Zeller <h.zeller@acm.org>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the BUILD.bazel file to define the visibility for the tcl_readline_setup target. The review feedback suggests several improvements to align the target with repository standards, including broadening the visibility to subpackages, applying standard compiler options (OPENROAD_COPTS), and disabling header modules to ensure compatibility with Tcl headers.
maliberty
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thus, it can use it as prepared in
The-OpenROAD-Project/OpenSTA#341