Fix 3dblox parser error by openroad-ci · Pull Request #10089 · The-OpenROAD-Project/OpenROAD

openroad-ci · 2026-04-08T20:13:30Z

Signed-off-by: Jorge Ferreira <jorge.ferreira@precisioninno.com>

github-actions · 2026-04-08T20:17:25Z

clang-tidy review says "All clean, LGTM! 👍"

gemini-code-assist

Code Review

This pull request enhances error reporting by automatically including the file path in BaseParser::logError and updating derived parsers to avoid redundant filename logging. Feedback suggests utilizing the logger's formatting capabilities in baseParser.cpp to avoid manual string concatenation and removing repetitive 'Parser Error' prefixes in the calls from dbvParser.cpp and dbxParser.cpp to prevent redundant output.

gemini-code-assist · 2026-04-08T20:19:04Z

src/odb/src/3dblox/baseParser.cpp

+  std::string msg = message;
+  if (!current_file_path_.empty()) {
+    msg = "in " + current_file_path_ + ": " + message;
+  }
+  logger_->error(utl::ODB, 521, "Parser Error: {} ", msg);


The error message construction contains an unnecessary trailing space in the format string and involves manual string concatenation. It is cleaner to use the logger's formatting capabilities directly to include the file path context. Note that calls to logger_->error are expected to terminate the program, so additional error handling is not necessary.

Suggested change

std::string msg = message;

if (!current_file_path_.empty()) {

msg = "in " + current_file_path_ + ": " + message;

}

logger_->error(utl::ODB, 521, "Parser Error: {} ", msg);

if (!current_file_path_.empty()) {

logger_->error(utl::ODB, 521, "Parser Error in {}: {}", current_file_path_, message);

} else {

logger_->error(utl::ODB, 521, "Parser Error: {}", message);

}

References

Calls to logger_->error are expected to terminate the program, so additional error handling like returning an error code or throwing an exception is not necessary.

gemini-code-assist · 2026-04-08T20:19:04Z

src/odb/src/3dblox/dbvParser.cpp

  std::ifstream file(filename);
  if (!file.is_open()) {
-    logError("3DBV Parser Error: Cannot open file: " + filename);
+    logError("3DBV Parser Error: Cannot open file");


The logError function already prefixes the message with "Parser Error:". Including "Parser Error" in the argument leads to redundant output (e.g., "Parser Error: ... 3DBV Parser Error: ...").

Suggested change

logError("3DBV Parser Error: Cannot open file");

logError("3DBV: Cannot open file");

gemini-code-assist · 2026-04-08T20:19:04Z

src/odb/src/3dblox/dbxParser.cpp

  std::ifstream file(filename);
  if (!file.is_open()) {
-    logError("DBX Parser Error: Cannot open file: " + filename);
+    logError("DBX Parser Error: Cannot open file");


The logError function already prefixes the message with "Parser Error:". Including "Parser Error" in the argument leads to redundant output (e.g., "Parser Error: ... DBX Parser Error: ...").

Suggested change

logError("DBX Parser Error: Cannot open file");

logError("DBX: Cannot open file");

jferreiraOpenRoad · 2026-04-08T20:22:14Z

The fix centralizes the file path in the 3dblox parser error report. Redundancies in dbxParser.cpp and dbvParser.cpp have been removed.

Signed-off-by: Jorge Ferreira <jorge.ferreira@precisioninno.com>

github-actions · 2026-04-08T20:47:26Z

clang-tidy review says "All clean, LGTM! 👍"

osamahammad21 · 2026-04-09T10:37:52Z

src/odb/src/3dblox/baseParser.cpp

 void BaseParser::logError(const std::string& message)
 {
-  logger_->error(utl::ODB, 521, "Parser Error: {}", message);
+  if (!current_file_path_.empty()) {


would that ever happen?

would that ever happen?

That's right, sorry for the mistake, I've already corrected it.

osamahammad21 · 2026-04-09T10:39:13Z

src/odb/src/3dblox/dbvParser.cpp

  std::ifstream file(filename);
  if (!file.is_open()) {
-    logError("3DBV Parser Error: Cannot open file: " + filename);
+    logError("3DBV Parser Error: Cannot open file");


Suggested change

logError("3DBV Parser Error: Cannot open file");

logError("Cannot open file");

osamahammad21 · 2026-04-09T10:39:32Z

src/odb/src/3dblox/dbxParser.cpp

  std::ifstream file(filename);
  if (!file.is_open()) {
-    logError("DBX Parser Error: Cannot open file: " + filename);
+    logError("DBX Parser Error: Cannot open file");


Suggested change

logError("DBX Parser Error: Cannot open file");

logError("Cannot open file");

osamahammad21 · 2026-04-09T10:41:11Z

src/odb/src/3dblox/baseParser.cpp

+    logger_->error(
+        utl::ODB, 521, "Parser Error in {}: {}", current_file_path_, message);
+  } else {
+    logger_->error(utl::ODB, 521, "Parser Error: {}", message);
+  }


Should not use the same error code for 2 separate errors.

Remove unreachable else branch in BaseParser::logError and simplify error messages in DbvParser and DbxParser by removing redundant prefixes already included by logError. Signed-off-by: Jorge Ferreira <jorge.ferreira@precisioninno.com>

github-actions · 2026-04-09T15:24:40Z

clang-tidy review says "All clean, LGTM! 👍"

Fix 3dblox parser error

35d6c86

Signed-off-by: Jorge Ferreira <jorge.ferreira@precisioninno.com>

openroad-ci assigned jferreiraOpenRoad Apr 8, 2026

gemini-code-assist bot reviewed Apr 8, 2026

View reviewed changes

fix: redundant error message in 3dblox parsers

6a11751

Signed-off-by: Jorge Ferreira <jorge.ferreira@precisioninno.com>

github-actions bot added the size/S label Apr 8, 2026

jferreiraOpenRoad requested a review from osamahammad21 April 8, 2026 20:51

osamahammad21 requested changes Apr 9, 2026

View reviewed changes

fix: address PR review comments on 3dblox parsers

ef69bbb

Remove unreachable else branch in BaseParser::logError and simplify error messages in DbvParser and DbxParser by removing redundant prefixes already included by logError. Signed-off-by: Jorge Ferreira <jorge.ferreira@precisioninno.com>

github-actions bot added size/XS and removed size/S labels Apr 9, 2026

	logError("3DBV Parser Error: Cannot open file");
	logError("3DBV: Cannot open file");

	logError("DBX Parser Error: Cannot open file");
	logError("DBX: Cannot open file");

	logError("3DBV Parser Error: Cannot open file");
	logError("Cannot open file");

Conversation

openroad-ci commented Apr 8, 2026

Uh oh!

github-actions bot commented Apr 8, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

jferreiraOpenRoad commented Apr 8, 2026

Uh oh!

github-actions bot commented Apr 8, 2026

Uh oh!

osamahammad21 Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

jferreiraOpenRoad Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

osamahammad21 Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

osamahammad21 Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

osamahammad21 Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants