bazel: Switch to tcl9, don't use runfiles anymore.

[hzeller]

We now can store a zipped set of tcl files for init.tcl and readline, so we don't need runfiles anymore.

Also advantage: the bazel-bin/openroad binary is now self-complete, so it can be copied anywhere as it does not need to find the tcl files relative to the binary anymore.

While at it, also update openmp: the previous version had some runfile that is actually not needed. So that helps us entirely not needing any runfiles anymore.

[gemini-code-assist]

Code Review

This pull request updates the openmp and tcl_lang dependencies to newer versions and enables the use_zipfs flag by default in bazel/BUILD. Feedback was provided to remove an outdated inline comment that is no longer accurate following the Tcl 9 migration.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[maliberty]

Does this help reduced the symlinking done when running tests?

[hzeller]

Yes. It reduces the symlinks to zero.

[hzeller]

(at least for openroad and opensta ussage. I have not looked if the tests do other symlinks)

[hzeller]

mmh, testing locally
//src/rsz/test:buffer_varying_lengths-tcl_test fails with
Error: buffer_varying_lengths.tcl, 105 can't read "sta::float_inf": no such variable

Maybe there is an issue mapping

https://github.com/The-OpenROAD-Project/OpenSTA/blob/6599d47d27d532f0662dbf8dab63577e5e7b93b5/util/Util.i#L52

with swig under Tcl 9 ?

[hzeller]

This happens when calling report_check_types defined in src/sta/search/Search.tcl

https://github.com/The-OpenROAD-Project/OpenSTA/blob/6599d47d27d532f0662dbf8dab63577e5e7b93b5/search/Search.tcl#L486-L494

Is there something special that we need to do to hage Searcch.tcl see the definition in Util.i ?

[hzeller]

Looks like CI also fails with this as well.
Do you have an idea what is amiss @maliberty ?

[maliberty]

I see it in ./sta/util/Util.i

float float_inf = INF;

I don't know why it isn't found.

[hzeller]

Will convert to draft for now and have a look separately when I find some time.

[hzeller]

Tried with latest swig 4.4.1 (which I am about to push to BCR), but that does not make a difference.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"