Bump spdlog 1.15.1 → 1.17.0#10104
Open
oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Open
Bump spdlog 1.15.1 → 1.17.0#10104oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
Minor version bump. If any spdlog API changed, the CMake build (DependencyInstaller.sh pins 1.15.0) may also need updating. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| bazel_dep(name = "or-tools", version = "9.15") | ||
| bazel_dep(name = "readline", version = "8.2.bcr.3") | ||
| bazel_dep(name = "spdlog", version = "1.15.1") | ||
| bazel_dep(name = "spdlog", version = "1.17.0") |
Contributor
There was a problem hiding this comment.
The pull request description notes that DependencyInstaller.sh pins spdlog to version 1.15.0. To maintain consistency across build systems and avoid potential discrepancies in behavior or API availability, please update the version in DependencyInstaller.sh to 1.17.0 as well.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor version bump. If any spdlog API changed, the CMake build (DependencyInstaller.sh pins 1.15.0) may also need updating.