Bump Boost 1.89.0.bcr.2 → 1.90.0.bcr.1#10105
Open
oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Open
Bump Boost 1.89.0.bcr.2 → 1.90.0.bcr.1#10105oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
Updates all 27 boost module deps via the BOOST_VERSION constant. Boost 1.89→1.90 is source-compatible; CMake build (1.89.0) should continue working. The boost.context parse_headers patch may need rebasing if it doesn't apply cleanly to 1.90. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the BOOST_VERSION constant in MODULE.bazel from 1.89.0 to 1.90.0. Feedback was provided regarding the importance of maintaining version parity between the Bazel and CMake build systems to avoid potential binary compatibility issues or build failures.
| bazel_dep(name = "swig", version = "4.3.0.bcr.2") | ||
|
|
||
| BOOST_VERSION = "1.89.0.bcr.2" | ||
| BOOST_VERSION = "1.90.0.bcr.1" |
Contributor
There was a problem hiding this comment.
The pull request description indicates that the CMake build remains at Boost 1.89.0. It is highly recommended to keep the Boost version consistent across all build systems (Bazel and CMake) to avoid potential binary compatibility issues or build failures if code changes start utilizing features specific to Boost 1.90.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates all 27 boost module deps via the BOOST_VERSION constant. Boost 1.89→1.90 is source-compatible; CMake build (1.89.0) should continue working. The boost.context parse_headers patch may need rebasing if it doesn't apply cleanly to 1.90.