Skip to content

rsz: design area include tap #9452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 18 commits into from
Feb 26, 2026
Merged

rsz: design area include tap #9452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
28985b9
rsz: design area calculation ignore only fill cells
gudeh Feb 9, 2026
a5e5dc0
Merge remote-tracking branch 'private/master' into rsz-design-area-in…
gudeh Feb 10, 2026
4c20895
rsz: compute area, include tap and end caps, diregard only fill cells
gudeh Feb 10, 2026
a8b4573
Merge remote-tracking branch 'private/master' into rsz-design-area-in…
gudeh Feb 12, 2026
0463caa
Merge remote-tracking branch 'private/master' into rsz-design-area-in…
gudeh Feb 13, 2026
5c91354
rsz: modify test after change in total design area calculation
gudeh Feb 13, 2026
0d3bf01
test: update after design area calculation by rsz
gudeh Feb 13, 2026
0eba890
Merge remote-tracking branch 'private/master' into rsz-design-area-in…
gudeh Feb 14, 2026
1b9f97f
Merge remote-tracking branch 'private/master' into rsz-design-area-in…
gudeh Feb 19, 2026
b97d5aa
Merge remote-tracking branch 'private/master' into rsz-design-area-in…
gudeh Feb 19, 2026
d0fc9a1
Merge remote-tracking branch 'private/master' into rsz-design-area-in…
gudeh Feb 24, 2026
0fe85b7
undo test modifications
gudeh Feb 24, 2026
04475ac
Merge remote-tracking branch 'private/master' into rsz-design-area-in…
gudeh Feb 24, 2026
74e94f7
Merge remote-tracking branch 'private/master' into rsz-design-area-in…
gudeh Feb 25, 2026
6ee5805
test: update after including tap and end cap in area calculation
gudeh Feb 25, 2026
1c9f2e0
Merge remote-tracking branch 'private/master' into rsz-design-area-in…
gudeh Feb 25, 2026
7e1fd69
test: update after design area calculation by rsz
gudeh Feb 25, 2026
ecec03d
Merge remote-tracking branch 'private/master' into rsz-design-area-in…
gudeh Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/rsz/src/Resizer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4174,9 +4174,7 @@ double Resizer::computeDesignArea()
for (dbInst* inst : block_->getInsts()) {
dbMaster* master = inst->getMaster();
// Don't count fillers otherwise you'll always get 100% utilization
if (!master->isFiller()
&& master->getType() != odb::dbMasterType::CORE_WELLTAP
&& !master->isEndCap()) {
if (!master->isFiller()) {
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly includes welltap and endcap cells in the design area calculation, it now relies solely on isFiller(), which seems to have an incomplete definition as it only identifies CORE_SPACER as a filler. Other filler-like cells such as PAD_SPACER and COVER cells will still be counted in the design area, which may not be desirable for an accurate utilization report.

For a more robust implementation that correctly excludes all filler types, consider this more comprehensive check.

    if (!master->isFiller() && !master->isCover() && master->getType() != odb::dbMasterType::PAD_SPACER) {

design_area += area(master);
}
}
Expand Down
100 changes: 50 additions & 50 deletions src/rsz/test/repair_setup_vt_swap2.ok
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
[WARNING RSZ-0075] makeBufferedNet failed for driver _569_/SN
[WARNING RSZ-0075] makeBufferedNet failed for driver _569_/SN
[WARNING RSZ-0075] makeBufferedNet failed for driver _571_/SN
50 | 0 | 35 | 0 | 1 | 13 | +0.6% | -5.965 | -18.3 | 44 | resp_msg[13]
50 | 0 | 35 | 0 | 1 | 13 | +0.5% | -5.965 | -18.3 | 44 | resp_msg[13]
[WARNING RSZ-0075] makeBufferedNet failed for driver _573_/CON
[WARNING RSZ-0075] makeBufferedNet failed for driver _570_/SN
[WARNING RSZ-0075] makeBufferedNet failed for driver _315_/Y
Expand All @@ -120,72 +120,72 @@
[WARNING RSZ-0075] makeBufferedNet failed for driver _569_/SN
[WARNING RSZ-0075] makeBufferedNet failed for driver _569_/SN
[WARNING RSZ-0075] makeBufferedNet failed for driver _368_/Y
58 | 0 | 40 | 0 | 1 | 16 | +0.6% | -4.375 | -13.6 | 42 | resp_msg[13]
58 | 0 | 40 | 0 | 1 | 16 | +0.5% | -4.375 | -13.6 | 42 | resp_msg[13]
[WARNING RSZ-0075] makeBufferedNet failed for driver _569_/SN
60 | 0 | 41 | 0 | 1 | 16 | +0.6% | -4.375 | -12.3 | 42 | resp_msg[13]
[WARNING RSZ-0075] makeBufferedNet failed for driver _569_/SN
[WARNING RSZ-0075] makeBufferedNet failed for driver _569_/SN
[WARNING RSZ-0075] makeBufferedNet failed for driver _368_/Y
62 | 0 | 43 | 0 | 1 | 16 | +0.7% | -4.375 | -10.3 | 40 | resp_msg[13]
62 | 0 | 43 | 0 | 1 | 16 | +0.6% | -4.375 | -10.3 | 40 | resp_msg[13]
[WARNING RSZ-0075] makeBufferedNet failed for driver _565_/SN
[WARNING RSZ-0075] makeBufferedNet failed for driver _565_/CON
[WARNING RSZ-0075] makeBufferedNet failed for driver _416_/Y
[WARNING RSZ-0075] makeBufferedNet failed for driver _363_/Y
[WARNING RSZ-0075] makeBufferedNet failed for driver dpath.a_reg.out\[11\]$_DFFE_PP_/QN
64 | 0 | 44 | 0 | 1 | 16 | +0.7% | -4.375 | -6.2 | 38 | resp_msg[13]
65 | 0 | 44 | 0 | 1 | 16 | +0.7% | -4.375 | -6.2 | 37 | resp_msg[13]
66 | 0 | 44 | 0 | 1 | 16 | +0.7% | -4.375 | -6.2 | 36 | resp_msg[13]
67 | 0 | 44 | 0 | 1 | 16 | +0.7% | -4.375 | -6.2 | 35 | resp_msg[13]
64 | 0 | 44 | 0 | 1 | 16 | +0.6% | -4.375 | -6.2 | 38 | resp_msg[13]
65 | 0 | 44 | 0 | 1 | 16 | +0.6% | -4.375 | -6.2 | 37 | resp_msg[13]
66 | 0 | 44 | 0 | 1 | 16 | +0.6% | -4.375 | -6.2 | 36 | resp_msg[13]
67 | 0 | 44 | 0 | 1 | 16 | +0.6% | -4.375 | -6.2 | 35 | resp_msg[13]
[WARNING RSZ-0075] makeBufferedNet failed for driver _563_/SN
[WARNING RSZ-0075] makeBufferedNet failed for driver _563_/SN
[WARNING RSZ-0075] makeBufferedNet failed for driver _563_/CON
70 | 0 | 45 | 0 | 1 | 17 | +0.7% | -4.379 | -5.0 | 35 | resp_msg[13]
70 | 0 | 45 | 0 | 1 | 17 | +0.6% | -4.379 | -5.0 | 35 | resp_msg[13]
[WARNING RSZ-0075] makeBufferedNet failed for driver _563_/SN
[WARNING RSZ-0075] makeBufferedNet failed for driver _563_/CON
71 | 0 | 44 | 0 | 1 | 16 | +0.7% | -4.375 | -6.2 | 34 | resp_msg[13]
71 | 0 | 44 | 0 | 1 | 16 | +0.6% | -4.375 | -6.2 | 34 | resp_msg[13]
[WARNING RSZ-0075] makeBufferedNet failed for driver _563_/SN
[WARNING RSZ-0075] makeBufferedNet failed for driver _563_/CON
73 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 32 | resp_msg[13]
74 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 31 | resp_msg[13]
75 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 30 | resp_msg[13]
76 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 29 | resp_msg[13]
77 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 28 | resp_msg[13]
78 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 27 | resp_msg[13]
79 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 26 | resp_msg[13]
80 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 26 | resp_msg[13]
80 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 25 | resp_msg[13]
81 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 24 | resp_msg[13]
82 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 23 | resp_msg[13]
83 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 22 | resp_msg[13]
84 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 21 | resp_msg[13]
85 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 20 | resp_msg[13]
86 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 19 | resp_msg[13]
87 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 18 | resp_msg[13]
88 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 17 | resp_msg[13]
89 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 16 | resp_msg[13]
90 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 16 | resp_msg[13]
90 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 15 | resp_msg[13]
91 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 14 | resp_msg[13]
92 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 13 | resp_msg[13]
93 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 12 | resp_msg[13]
94 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 11 | resp_msg[13]
95 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 10 | resp_msg[13]
96 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 9 | resp_msg[13]
97 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 8 | resp_msg[13]
98 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 7 | resp_msg[13]
99 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 6 | resp_msg[13]
100 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 6 | resp_msg[13]
100 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 5 | resp_msg[13]
101 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 4 | resp_msg[13]
102 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 3 | resp_msg[13]
103 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 2 | resp_msg[13]
104 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 1 | resp_msg[13]
105 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 0 | resp_msg[13]
106 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 0 | resp_msg[13]
107 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 0 | resp_msg[13]
108 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 0 | resp_msg[13]
109 | 0 | 45 | 0 | 1 | 16 | +0.7% | -4.375 | -4.8 | 0 | resp_msg[13]
final | 0 | 56 | 0 | 1 | 16 | +0.7% | -4.375 | -4.4 | 1 | resp_msg[13]
73 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 32 | resp_msg[13]
74 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 31 | resp_msg[13]
75 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 30 | resp_msg[13]
76 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 29 | resp_msg[13]
77 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 28 | resp_msg[13]
78 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 27 | resp_msg[13]
79 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 26 | resp_msg[13]
80 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 26 | resp_msg[13]
80 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 25 | resp_msg[13]
81 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 24 | resp_msg[13]
82 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 23 | resp_msg[13]
83 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 22 | resp_msg[13]
84 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 21 | resp_msg[13]
85 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 20 | resp_msg[13]
86 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 19 | resp_msg[13]
87 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 18 | resp_msg[13]
88 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 17 | resp_msg[13]
89 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 16 | resp_msg[13]
90 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 16 | resp_msg[13]
90 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 15 | resp_msg[13]
91 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 14 | resp_msg[13]
92 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 13 | resp_msg[13]
93 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 12 | resp_msg[13]
94 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 11 | resp_msg[13]
95 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 10 | resp_msg[13]
96 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 9 | resp_msg[13]
97 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 8 | resp_msg[13]
98 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 7 | resp_msg[13]
99 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 6 | resp_msg[13]
100 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 6 | resp_msg[13]
100 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 5 | resp_msg[13]
101 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 4 | resp_msg[13]
102 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 3 | resp_msg[13]
103 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 2 | resp_msg[13]
104 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 1 | resp_msg[13]
105 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 0 | resp_msg[13]
106 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 0 | resp_msg[13]
107 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 0 | resp_msg[13]
108 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 0 | resp_msg[13]
109 | 0 | 45 | 0 | 1 | 16 | +0.6% | -4.375 | -4.8 | 0 | resp_msg[13]
final | 0 | 56 | 0 | 1 | 16 | +0.6% | -4.375 | -4.4 | 1 | resp_msg[13]
--------------------------------------------------------------------------------------------------------------
[INFO RSZ-0051] Resized 56 instances: 4 up, 0 up match, 0 down, 52 VT
[INFO RSZ-0043] Swapped pins on 16 instances.
Expand Down
Loading