mpl: treat virtual pin access blockages as soft constraints#9465
mpl: treat virtual pin access blockages as soft constraints#9465AcKoucher wants to merge 3 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the handling of blockages, treating virtual pin access blockages as soft constraints. This is achieved by renaming macro_blockage related concepts to soft_blockage throughout the codebase, and separating the handling of placement_blockages (hard constraints) from io_blockages (now soft constraints). The changes are extensive and touch many files, including documentation, C++ source, and TCL scripts. The review found a critical issue related to coordinate systems. A newly introduced generic function for finding intersections fails to transform coordinates to the relative system used by the placement engine, which was correctly handled by the previous implementation. This will likely lead to incorrect placement. A minor issue with a stale log message was also found.
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@joaomai FYI. |
1 participant
See #9214 for the rationale.
Resolve #9226.