added asap7 augmented library + coverity fix + vt fix#9488
added asap7 augmented library + coverity fix + vt fix#9488openroad-ci wants to merge 4 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several valuable improvements. It adds support for the ASAP7 augmented library along with a new test case, which is a great addition. The fixes for the potential division-by-zero (Coverity issue), the VT layer hashing logic, and the memory leak in the SWIG wrapper are all well-implemented and improve the robustness and correctness of the code. I have one minor suggestion for the newly added LEF file to improve its clarity.
| TYPE ROUTING ; | ||
| DIRECTION VERTICAL ; |
There was a problem hiding this comment.
There are redundant TYPE ROUTING and DIRECTION VERTICAL declarations within the M7 layer definition. These are already declared on lines 541-542. Removing these duplicate lines will improve clarity and prevent potential parsing issues.
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
2 participants
Uh oh!
There was an error while loading. Please reload this page.