Skip to content

Tell compilation db where to find the Python.h includes. #9506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 1 commit into from
Feb 23, 2026
Merged

Tell compilation db where to find the Python.h includes. #9506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions etc/bazel-make-compilation-db.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,16 @@ done >> compile_flags.txt
# Qt include files check for this
echo '-fPIC' >> compile_flags.txt

# Python include bindings.
for f in bazel-out/../../../external/*/include/python3.*/Python.h; do
Copy link
Copy Markdown
Member

@maliberty maliberty Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bazel-out/.. is a no-op, what is the intention in including it?

Copy link
Copy Markdown
Collaborator Author

@hzeller hzeller Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bazel-out/ is a symlink that points to the bazel internal directories.

if [ -f "${f}" ]; then
PY_INC="$(dirname "${f}")"
echo "-I${PY_INC}"
echo "-I$(realpath "${PY_INC}")" # work around clangd bug
break
fi
done >> compile_flags.txt

# Since we don't do per-file define extraction in compile_flag.txt,
# add them here globally
cat >> compile_flags.txt <<EOF
Expand Down