rsz: Improve error message for RSZ-0074#9514
rsz: Improve error message for RSZ-0074#9514eder-matheus merged 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
|
@eder-matheus can you please check this PR? I also didn't test it with the issue in The-OpenROAD-Project/OpenROAD-flow-scripts#3890 (reply in thread) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request improves the error message for RSZ-0074 by adding the pin name and grid coordinates, which is helpful for debugging. However, several critical syntax errors were introduced that will prevent the code from compiling, including a typo in a member access (network_-_>) and a missing comma in the logger_->error call. Additionally, the new variable drvr_pin_pt is redundant because the drvr_pin parameter is already available in the function scope, and its declared type PinPt appears to be undefined. It is recommended to remove the redundant variable and fix the syntax errors in the error message call.
dnltz
force-pushed
the
WIP/dnltz/rsz-fix-error-msg
branch
from
b597200 to
fda28d2
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dnltz
force-pushed
the
WIP/dnltz/rsz-fix-error-msg
branch
2 times, most recently
from
dff8664 to
d093db8
Compare
oharboe
left a comment
oharboe
left a comment
There was a problem hiding this comment.
Translating from an error message to location in GUI is tedious, the DRC error dropdown does that for us, e.g. PDN errors are listed there.
That's beyond the scope of the improvement in this PR, but related, so I thought I'd mention it.
Is there a mechanism today to add warnings/errors by category, such as PDN does, to the DRC viewer?
This error won't generate any ODB file. So, not sure how to watch this violation. |
dnltz
force-pushed
the
WIP/dnltz/rsz-fix-error-msg
branch
from
d093db8 to
62d6fc1
Compare
dnltz
force-pushed
the
WIP/dnltz/rsz-fix-error-msg
branch
from
62d6fc1 to
f3ea844
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@eder-matheus can you please re-run the failed CI run? |
This failure is happening on master branch too, so it'll not be resolved by just re-running. @maliberty how should we proceed? |
|
@dnltz Could you please merge the latest master to your branch? It should help with the failure. |
The currently printed error message is not really helpful for debugging: failed to build tree from gloubal routes: found route to 1 pins, expected 0 Add the pin name and grid x + y values to the error message. Also fix a typo. Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
dnltz
force-pushed
the
WIP/dnltz/rsz-fix-error-msg
branch
from
f3ea844 to
9eb8846
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
3 participants
The currently printed error message is not really helpful for debugging:
failed to build tree from gloubal routes: found route to 1 pins, expected 0
Add the pin name and grid x + y values to the error message. Also fix a typo.