Support Kali GNU/Linux and generic Debian derivatives in DependencyInstaller#9522
Support Kali GNU/Linux and generic Debian derivatives in DependencyInstaller#9522Subhankar-hub wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
…staller Kali and other Debian derivatives fail to install dependencies because the OS detection only matches exact distro names. This patch: - Add "Kali GNU/Linux" and wildcard "Debian GNU/Linux"* to OS case match - Fall back to libtcl8.6 when the virtual libtcl package has no candidate - Auto-detect Python version instead of hardcoding 3.8 - Normalize non-standard Debian version IDs (e.g. Kali's 2025.4) to Debian 12 for the or-tools download URL - Add -DCMAKE_POSITION_INDEPENDENT_CODE=ON to Abseil build for GCC 15+ where PIE is the default Fixes The-OpenROAD-Project/OpenROAD-flow-scripts#3910 Co-authored-by: Cursor <cursoragent@cursor.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly improves the dependency installation script for Debian-based systems, adding support for derivatives like Kali GNU/Linux. The changes are robust and well-implemented. Key improvements include adding a wildcard for Debian distributions, providing a fallback for the libtcl package, dynamically detecting the Python version, and normalizing non-standard version IDs for downloading or-tools. The addition of the CMAKE_POSITION_INDEPENDENT_CODE flag for Abseil is also a necessary fix for compatibility with modern compilers. Overall, these are excellent enhancements that increase the script's flexibility and maintainability.
|
Note that commits need to be signed ( |
|
clang-tidy review says "All clean, LGTM! 👍" |
2 participants
Summary
"Kali GNU/Linux"and wildcard"Debian GNU/Linux"*to OS case match so Debian derivatives are recognizedlibtcl8.6when the virtuallibtclpackage has no install candidate3.8for Debian2025.4) to Debian12for the or-tools download URL-DCMAKE_POSITION_INDEPENDENT_CODE=ONto Abseil cmake config for GCC 15+ where PIE is the defaultTest plan
setup.shon Kali GNU/Linux 2025.4 (GCC 15.2, Python 3.13, glibc 2.42)openroad -versionsucceeds)Fixes The-OpenROAD-Project/OpenROAD-flow-scripts#3910
Made with Cursor