Restore statetable check in hasSequentials and add MBFF regression test#345
Open
openroad-ci wants to merge 3 commits intoThe-OpenROAD-Project:masterfrom
Open
Conversation
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
…eeded Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
maliberty
reviewed
Apr 10, 2026
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
maliberty
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore statetable_ check in LibertyCell::hasSequentials() — Upstream(Parallaxsw/OpenSTA) commit 6742692 ("string squash") inadvertently removed the || statetable_ != nullptr condition that was added in 7b87209 ("liberty statetables"). Cells that define sequential behavior only via a statetable group (no ff/latch) — common in MBFFs and clock-gated cells — were misclassified as combinational. This broke power categorization, resizer sequential guards, and dbSta cell-type mapping.
Add C++ regression test (HasSequentialsStatetableMBFF) — creates a 2-bit MBFF cell with statetable-only sequential definition, verifies hasSequentials() returns true.
Fix Coverity FORWARD_NULL in LibertyPort::less() — the both-null case fell through to dereference port1->name().