feat: leetcode zigzag solution by straight-into-the-wall · Pull Request #897 · TheAlgorithms/C

straight-into-the-wall · 2021-10-22T14:24:57Z

Description of Change

A solution for the ZigZag conversion problem.

References

Hacktoberfest issue

ZigZag Conversion problem on leetcode

Checklist

Added description of change
Added file name matches File name guidelines
Added tests and example, test must pass
Relevant documentation/comments is changed or added
PR title follows semantic commit guidelines
Search previous suggestions before making a new one, as yours may be a duplicate.
I acknowledge that all my contributions will be made under the project's license.

Notes: Solution to the 6-ZigZag conversion problem was missing. Here is (decent) one.

ZigZagConversion-SubmissionDetail-LeetCode.pdf

straight-into-the-wall · 2021-10-22T14:41:32Z

Hey @Panquesito7 @kvedala,

On my fork's Github Actions I got this error from Awesome CI Workflow Code formatter; even if I separated the two files into two different commits.

2 files are not in one and only one directory:
leetcode/src/1.c
leetcode/src/6.c

Error: Process completed with exit code 2.

Any idea how I could fix it?

Thanx

Panquesito7

Good work! 😄👍

leetcode/src/6.c

@file does not want parameters Co-authored-by: David Leal <halfpacho@gmail.com>

Co-authored-by: David Leal <halfpacho@gmail.com>

Panquesito7

Please fix clang-tidy warnings. Let us know if you need any help here or in our Discord server. 😃

Panquesito7

Still failing here.

straight-into-the-wall · 2021-10-24T21:31:45Z

I've done clang-tidy --fix --quiet -p build leetcode/src/6.c -- on my side without any warning. The Awesome CI error message is quite cryptic 1 files are not in one and only one directory. I've checked and didn't find any other file named 6.c in the whole repo. ... waiting for help on #898 and Discord server.

This reverts commit b46a6af.

straight-into-the-wall · 2021-10-25T16:45:09Z

solved by PR #900 ?

Panquesito7 · 2021-10-31T16:57:38Z

Still failing. 👀

straight-into-the-wall · 2021-10-31T22:23:41Z

Somehow this PR was again tested with the buggy version of awesome_workflow.yml:

You can see in the details of the failing check.

and then in failing workflow file:

Master branch now seems to have the right .github/workflows/awesome_workflow.yml

... Maybe relaunch the tests ?

leetcode/src/6.c

Co-authored-by: David Leal <halfpacho@gmail.com>

Panquesito7 · 2021-11-05T02:52:55Z

I've seen the tests are failing in other PRs with the same issue you had in this PR. Would you like to investigate? Thanks. 🙂

straight-into-the-wall · 2021-11-08T21:16:03Z

I've seen the tests are failing in other PRs with the same issue you had in this PR. Would you like to investigate? Thanks. slightly_smiling_face

I checked some of the waiting PR but any of them has the same issue that this one. Could you link some references?

Panquesito7 · 2021-11-08T22:44:49Z

I've seen the tests are failing in other PRs with the same issue you had in this PR. Would you like to investigate? Thanks. 🙂

I checked some of the waiting PR but any of them has the same issue that this one. Could you link some references?

#914

Panquesito7

A question: there's no main function? 🤔

straight-into-the-wall · 2021-11-21T13:50:44Z

A question: there's no main function?

@Panquesito7

added main function.

Panquesito7

Almost there! 😄

leetcode/src/6.c

Panquesito7

LGTM 🚀 Thanks for your contribution! 😄👍

straight-into-the-wall · 2021-12-09T02:14:04Z

@ayaankhan98 @mishraabhinn @Panquesito7 ... ping? 😉

straight-into-the-wall and others added 7 commits October 21, 2021 16:20

perf: faster implementation of the TwoSum problem

4ff5849

doc: fixed typos on comments

6453a9e

updating DIRECTORY.md

80e54d9

feat: leetcode ZigZag conversion solution

e45b4d9

doc: leetcode README added ZigZag conversion solution

6d3985c

fix: clang-tidy linter corrections

ab710ee

doc: fixed typo on leetcode README

9e8e4b8

straight-into-the-wall marked this pull request as ready for review October 22, 2021 14:29

straight-into-the-wall mentioned this pull request Oct 22, 2021

Awesome CI Workflow Code formater: "2 files are not in one and only one directory" but they are in separate branches. #898

Closed

Panquesito7 requested changes Oct 22, 2021

View reviewed changes

leetcode/src/6.c Outdated Show resolved Hide resolved

leetcode/src/6.c Outdated Show resolved Hide resolved

leetcode/src/6.c Outdated Show resolved Hide resolved

leetcode/src/6.c Outdated Show resolved Hide resolved

Panquesito7 added Autochecks are failing Failing CI Auto-checks Changes requested enhancement New feature or request labels Oct 22, 2021

straight-into-the-wall and others added 5 commits October 22, 2021 19:32

Update leetcode/src/6.c

495d780

@file does not want parameters Co-authored-by: David Leal <halfpacho@gmail.com>

Update leetcode/src/6.c

30f3cea

Co-authored-by: David Leal <halfpacho@gmail.com>

fix: unsigned int and include comments

335fbb0

fix: merging static test func

420628e

fix: comments on includes. Doxygen file. static test function

23c0485

straight-into-the-wall requested a review from Panquesito7 October 24, 2021 10:55

Panquesito7 requested changes Oct 24, 2021

View reviewed changes

straight-into-the-wall added 2 commits October 24, 2021 23:05

Merge branch 'master' into leetcode/zigzag

b46a6af

fix: add missing headers

ce5fb53

Panquesito7 requested changes Oct 24, 2021

View reviewed changes

straight-into-the-wall added 2 commits October 24, 2021 23:58

Delete 1.c

35a75f4

Revert "Merge branch 'master' into leetcode/zigzag"

3a627d7

This reverts commit b46a6af.

straight-into-the-wall added 2 commits October 25, 2021 19:49

Merge branch 'master' of github.com:TheAlgorithms/C

13330eb

fix: revert 1.c

e57c16d

Panquesito7 mentioned this pull request Oct 31, 2021

Revert "fix: #898 another fix for Awesome workflow nodir_files problem" #907

Merged

Empty commit to test the CI

a18708c

Panquesito7 removed the Autochecks are failing Failing CI Auto-checks label Oct 31, 2021

Panquesito7 reviewed Oct 31, 2021

View reviewed changes

leetcode/src/6.c Outdated Show resolved Hide resolved

leetcode/src/6.c Outdated Show resolved Hide resolved

straight-into-the-wall and others added 2 commits November 4, 2021 21:40

Update leetcode/src/6.c

def0eb6

Co-authored-by: David Leal <halfpacho@gmail.com>

Update leetcode/src/6.c

143a741

Co-authored-by: David Leal <halfpacho@gmail.com>

Merge branch 'TheAlgorithms:master' into master

00985b4

Panquesito7 reviewed Nov 10, 2021

View reviewed changes

straight-into-the-wall and others added 4 commits November 21, 2021 14:27

Merge remote-tracking branch 'upstream/master'

1f4a876

fix: missing main

d7923cd

Merge branch 'master' into leetcode/zigzag

ec83f11

updating DIRECTORY.md

fca859c

Panquesito7 reviewed Nov 21, 2021

View reviewed changes

leetcode/src/6.c Outdated Show resolved Hide resolved

leetcode/src/6.c Show resolved Hide resolved

doc: added missing comment

3af6340

straight-into-the-wall requested a review from Panquesito7 November 21, 2021 21:54

Panquesito7 approved these changes Nov 21, 2021

View reviewed changes

Panquesito7 added approved Approved; waiting for merge and removed Changes requested labels Nov 21, 2021

Panquesito7 requested review from aminoxix, ayaankhan98 and mishraabhinn November 21, 2021 22:11

aminoxix approved these changes Nov 24, 2021

View reviewed changes

Panquesito7 merged commit 37534f4 into TheAlgorithms:master Dec 9, 2021

Uh oh!

Conversation

straight-into-the-wall commented Oct 22, 2021 • edited by gitpod-io bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

References

Checklist

Uh oh!

straight-into-the-wall commented Oct 22, 2021

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

straight-into-the-wall commented Oct 24, 2021

Uh oh!

straight-into-the-wall commented Oct 25, 2021

Uh oh!

Panquesito7 commented Oct 31, 2021

Uh oh!

straight-into-the-wall commented Oct 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Panquesito7 commented Nov 5, 2021

Uh oh!

straight-into-the-wall commented Nov 8, 2021

Uh oh!

Panquesito7 commented Nov 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

straight-into-the-wall commented Nov 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

straight-into-the-wall commented Dec 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

straight-into-the-wall commented Oct 22, 2021 •

edited by gitpod-io bot

Loading

straight-into-the-wall commented Oct 31, 2021 •

edited

Loading

Panquesito7 commented Nov 8, 2021 •

edited

Loading

straight-into-the-wall commented Nov 21, 2021 •

edited

Loading