Add student result processor utility #14185
Conversation
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def separate_students(students, pass_mark=75): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/student_result_processor.py, please provide doctest for the function separate_students
Please provide return type hint for the function: separate_students. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: students
Please provide type hint for the parameter: pass_mark
| return passed, failed | ||
|
|
||
|
|
||
| def top_performers(students, threshold=90): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/student_result_processor.py, please provide doctest for the function top_performers
Please provide return type hint for the function: top_performers. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: students
Please provide type hint for the parameter: threshold
| return [s for s in students if s["marks"] >= threshold] | ||
|
|
||
|
|
||
| def pass_percentage(students, pass_mark=75): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/student_result_processor.py, please provide doctest for the function pass_percentage
Please provide return type hint for the function: pass_percentage. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: students
Please provide type hint for the parameter: pass_mark
1 participant
Description
This PR adds a simple, beginner-friendly Python utility to process student results.
What it does
Notes
other/directoryPlease let me know if any changes are required. Thanks for maintaining this great repository!