Skip to content

Improve isogram handling by ignoring non-alphabetic characters #14250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tithi234 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve isogram handling by ignoring non-alphabetic characters #14250

Tithi234 wants to merge 3 commits into from
+7 −10

Conversation

@Tithi234
Copy link
Contributor

@Tithi234 Tithi234 commented Feb 5, 2026

Describe your change:

  • Improves isogram detection by ignoring non-alphabetic characters
  • Simplifies logic while keeping the same algorithmic intent
  • Makes behavior more practical for real-world strings

What type of change is this?

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md
  • This pull request is all my own work
  • I know that pull requests will not be merged if they fail the automated tests
  • This PR only changes one algorithm file
  • All functions and variable names follow Python naming conventions
  • All function parameters and return values are annotated with Python type hints
  • All functions have doctests that pass the automated testing

@Tithi234
Improve isogram check by ignoring non-alphabetic characters
8a6d45a 
Updated docstring to clarify isogram definition and added example with non-alphabetic characters. Modified letter extraction to ignore non-alphabetic characters.
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Feb 5, 2026
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mindaugl mindaugl mindaugl approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tithi234 @mindaugl