Attempting to improve compiler error messages related to tag_invoke#6843
Open
Attempting to improve compiler error messages related to tag_invoke#6843
Conversation
hkaiser
force-pushed
the
fixing_6718
branch
3 times, most recently
from
775733c to
f8cc4e5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| template <executor_any Executor, typename F, typename... Ts> | ||
| requires(std::invocable<F &&, Ts && ...>) | ||
| HPX_FORCEINLINE constexpr decltype(auto) operator()( | ||
| Executor&& exec, F&& f, Ts&&... ts) const |
Check notice
Code scanning / CodeQL
Unused local variable Note
| typename... Ts> | ||
| requires(std::invocable<F &&, shape_value_type_t<Shape>, Ts && ...>) | ||
| HPX_FORCEINLINE constexpr decltype(auto) operator()( | ||
| Executor&& exec, F&& f, Shape const& shape, Ts&&... ts) const |
Check notice
Code scanning / CodeQL
Unused static variable Note
| typename... Ts> | ||
| requires(std::invocable<F &&, shape_value_type_t<Shape>, Ts && ...>) | ||
| HPX_FORCEINLINE constexpr decltype(auto) operator()( | ||
| Executor&& exec, F&& f, Shape const& shape, Ts&&... ts) const |
Check notice
Code scanning / CodeQL
Unused local variable Note
Contributor
Author
|
retest lsu |
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
- this is an experiment of how to best improve generated error messages if no appropriate tag_invoke overloads are being available Signed-off-by: Hartmut Kaiser <hartmut.kaiser@gmail.com>
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experiment of how to best improve generated error messages if no appropriate
tag_invokeoverloads are being available.The main idea is to add explicit
operator()()overload(s) to the customization point object that concept-check all arguments. Theseoperator()()overloads simply forward to the base-class dispatch logic. This has the additional benefit of centralized argument concept-checking for alltag_invokeoverloads provided.If this proves to be applicable it opens up a path to fixing #6718.