Ensure the typing package is installed only if needed (python < 3.5)#27
Open
WuShell wants to merge 2 commits intoTheHive-Project:masterfrom
Open
Ensure the typing package is installed only if needed (python < 3.5)#27WuShell wants to merge 2 commits intoTheHive-Project:masterfrom
WuShell wants to merge 2 commits intoTheHive-Project:masterfrom
Conversation
This prevents problems when installing cortex4py in recent python versions, where typing is installed as an external package, while there is a typing module included in the stdlib. The external package then "shadows" the stdlib module, breaking other packages that use/rely on typing (when using cortex4py in a project with more dependencies)
|
Hey, just wanted to bump this one if possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents problems when installing cortex4py in recent python versions, where typing is installed as an external package, while there is a typing module included in the stdlib.
The external package then "shadows" the stdlib module, breaking other packages that use/rely on typing (when using cortex4py in a project with more dependencies)
I've used the suggested "incantation" to set up typing as a required dependency from the project site, here:
https://pypi.org/project/typing/
"For package maintainers, it is preferred to use typing;python_version<"3.5" if your package requires it to support earlier Python versions. This will avoid shadowing the stdlib typing module when your package is installed via pip install -t . on Python 3.5 or later."
Tested locally with python 3.7, 3.8 and 3.9