Skip to content

Comments

Fix search input in list views in the Console#7833

Merged
nicholaspcr merged 1 commit intov3.35from
fix/list-search-focus
Feb 19, 2026
Merged

Fix search input in list views in the Console#7833
nicholaspcr merged 1 commit intov3.35from
fix/list-search-focus

Conversation

@ryaplots
Copy link
Contributor

Summary

References https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1415

Changes

  • Remove disabling

Testing

Steps

Follow the steps in cybereye issue.

Regressions
  • Removing the disabling will mean the the field won't be disabled while the fetching for new entries is happening

Notes for Reviewers

There were two ways of fixing this:

  1. Make the field not disabled at the risk that the user will change the input while the fetch is still happening
  2. Adding more logic to the fetch table which is already huge to track that field and check is it was focused before, refocus it again.

I went for option 1. Let me know what you think


Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots self-assigned this Feb 18, 2026
@ryaplots ryaplots requested a review from a team as a code owner February 18, 2026 12:40
@ryaplots ryaplots added the ui/web This is related to a web interface label Feb 18, 2026
@nicholaspcr nicholaspcr added this to the v3.36.0 milestone Feb 18, 2026
Copy link
Contributor

@PavelJankoski PavelJankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the fix. Approved.

@PavelJankoski
Copy link
Contributor

Agree with the fix. Approved.

@ryaplots Actually, another alternative is if instead of disabled we use readonly when fetching. Can you try that before merging? I think the input won't lose focus with that.

@nicholaspcr nicholaspcr merged commit 0b60b8e into v3.35 Feb 19, 2026
12 of 13 checks passed
@nicholaspcr nicholaspcr deleted the fix/list-search-focus branch February 19, 2026 12:53
@nicholaspcr
Copy link
Contributor

@PavelJankoski My apologies mate, I just saw it being approved and merged it.
Should I create the PR to revert these changes?

@ryaplots ryaplots restored the fix/list-search-focus branch February 19, 2026 13:25
@ryaplots ryaplots mentioned this pull request Feb 19, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui/web This is related to a web interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants