fix: AI message dismiss button #1403
Conversation
when message that created thread was deleted, retrieveStartMessage() threw an error UNKNOWN_MESSAGE leading to non-functional dismiss button. this adds a handler, specifically for parent message deleted error by using getIterableHistoryInstead.
| .build(); | ||
| private final ComponentIdInteractor componentIdInteractor = | ||
| new ComponentIdInteractor(getInteractionType(), getName()); | ||
| private static final int FIRST_MESSAGE_ONLY = 1; |
There was a problem hiding this comment.
The naming is a bit off and perhaps something you would give to a boolean. Instead, let's rename this to NUMBER_OF_MESSAGES + some additional context.
There was a problem hiding this comment.
moved to function's scope and renamed it for clarity
| ThreadChannel channel = event.getChannel().asThreadChannel(); | ||
| Member interactionUser = Objects.requireNonNull(event.getMember()); | ||
|
|
||
| Consumer<Throwable> handleParentMessageDeleted = error -> { |
There was a problem hiding this comment.
You can extract this as it's own function as opposed to defining it like this.
| .build(); | ||
| private final ComponentIdInteractor componentIdInteractor = | ||
| new ComponentIdInteractor(getInteractionType(), getName()); | ||
| private static final int FIRST_MESSAGE_ONLY = 1; |
There was a problem hiding this comment.
this constant cant be understood without context. i would move it down as local var next to where its used so the context is available. and then the name can also be more like that, bc the context is available
| } | ||
| }); | ||
| } else { | ||
| log.error("Failed to retrieve start message: ", error); |
There was a problem hiding this comment.
add context to the log, so its easier to work with when we see it in the monitoring. sth like
Trying to dismiss automatic help message for thread (id: ...) but cannot find original message.
* move AI dismiss fallback consumer to a seperate function for clarity * move variable FIRST_MESSAGE_ONLY to function scope as noOfMessage for clarity * improve error log message for clarity
3 participants
when message that created thread was deleted,
retrieveStartMessage() threw an error UNKNOWN_MESSAGE leading to non-functional dismiss button.
this adds a handler, specifically for parent message deleted error by using getIterableHistoryInstead.
resolves #1400