Skip to content

hotfix(MessageCommand): do not allow anybody to call this command#1407

Open
christolis wants to merge 1 commit intoTogether-Java:developfrom
christolis:hotfix/message-perms
Open

hotfix(MessageCommand): do not allow anybody to call this command#1407
christolis wants to merge 1 commit intoTogether-Java:developfrom
christolis:hotfix/message-perms

Conversation

@christolis
Copy link
Member

No description provided.

Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>
@christolis christolis requested a review from a team as a code owner February 4, 2026 14:08
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

voting to close this. we removed all in-code perm checks because this is something discord provides on its own and lets owners configure in much more detail and ease inside discord

if u add this u would also have to add it for /ban and all other sensitive commands.

@christolis
Copy link
Member Author

christolis commented Feb 4, 2026

There is a ModerationUtils in the code that is currently being used to prevent people from calling certain commands, what about that? That's what I was planning to use originally actually but it turns out it's only visible in the context of that package it's in.

@Zabuzard
Copy link
Member

Zabuzard commented Feb 4, 2026

There is a ModerationUtils in the code that is currently being used to prevent people from calling certain commands, what about that? That's what I was planning to use originally actually but it turns out it's only visible in the context of that package it's in.

Thats slightly different I would say. It is to ensure transitive permission dependencies. So for example to ensure a user who is mod cant ban an admin, only vice versa.

We removed all in-code perm checks like "/ban can only be used by users with ban permission" the moment discord added this stuff in their own preferred UI.

Either case, the urgency is gone, we dont need a hotfix anymore, so we have time to think this through carefully and dont need to act immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants