Fixing a JSON crash on saved weapon loadout data#551
Open
Gravxd wants to merge 1 commit intoTomGrobbe:masterfrom
Open
Fixing a JSON crash on saved weapon loadout data#551Gravxd wants to merge 1 commit intoTomGrobbe:masterfrom
Gravxd wants to merge 1 commit intoTomGrobbe:masterfrom
Conversation
… the menu building
cm8263
requested changes
Mar 22, 2026
| { | ||
| SavedWeapons.Add(save, JsonConvert.DeserializeObject<List<ValidWeapon>>(kvpValue)); | ||
| } | ||
| catch |
Collaborator
There was a problem hiding this comment.
Let's throw a JsonException (or even just an Exception) on the catch so we can see what's causing the error - might help us fix it in the future 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how it happens but some clients get this error which persists across servers running different game builds and other data. Somehow their client sided data is corrupted, this code just provides a quick fix so that it doesn't crash building the menu making vMenu unusable for that client.