Fixed animated group textures not animating by Nickelony · Pull Request #1124 · TombEngine/Tomb-Editor

Nickelony · 2026-02-12T20:19:47Z

This pull request introduces robust support for animated texture sub-areas - enabling tools that apply textures to only a portion of an animated frame (such as group texturing) to work seamlessly. The changes include a new utility for matching and generating sub-area animation sets, cache key structures for deduplication, and integration with both the general and TombEngine-specific texture managers. Additionally, some redundant code related to resetting texture parent areas was removed.

Animated texture sub-area support:

Added AnimatedTextureLookupUtility with methods for matching, quantizing, and generating sub-area animation sets, as well as a SubAreaKey struct for deduplicating sub-area lookups. (TombLib/TombLib/LevelData/Compilers/AnimatedTextureLookupUtility.cs)
Integrated sub-area animated texture matching and lookup generation into both TexInfoManager and TombEngineTexInfoManager, including logic to handle only compatible animation types and prevent redundant processing via _processedSubAreas. (TombLib/TombLib/LevelData/Compilers/Util/TexInfoManager.cs, TombLib/TombLib/LevelData/Compilers/TombEngine/TombEngineTexInfoManager.cs) [1] [2] [3] [4] [5]
Modified the animated lookup generation to accept a isForRoom parameter, ensuring correct scoping of generated lookups. (TombLib/TombLib/LevelData/Compilers/Util/TexInfoManager.cs) [1] [2]

Code cleanup and bug fixes:

Removed unnecessary resetting of texture.ParentArea before applying textures, preventing accidental loss of parent area information needed for sub-area matching. (TombEditor/EditorActions.cs) [1] [2]

Dependency management:

Added missing using directive for the new utility in TexInfoManager. (TombLib/TombLib/LevelData/Compilers/Util/TexInfoManager.cs)

Copilot

Pull request overview

Fixes a compiler-side issue where animated textures applied as sub-areas (via group texturing tools using ParentArea) were not being recognized as animated, causing them to compile as static textures instead.

Changes:

Detects textures with a non-zero ParentArea and attempts to match them against reference animated textures using reconstructed “full-frame” UVs.
When a match is found, synthesizes a sub-area AnimatedTextureSet, generates lookup entries for it, and retries AddTexture so the sub-area can be treated as animated.
Implements the same logic in both the classic TR compiler texinfo manager and the TombEngine texinfo manager.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.

File	Description
TombLib/TombLib/LevelData/Compilers/Util/TexInfoManager.cs	Adds sub-area animated-texture detection + synthetic sub-animation lookup generation for classic/TR compilers.
TombLib/TombLib/LevelData/Compilers/TombEngine/TombEngineTexInfoManager.cs	Mirrors the sub-area animated-texture handling for TombEngine texture compilation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Nickelony · 2026-03-23T00:38:26Z

This PR is now complete and ready for review.

Lwmte · 2026-04-18T19:32:23Z

            if(!disableUndo)
                _editor.UndoManager.PushGeometryChanged(_editor.SelectedRoom);

-            texture.ParentArea = new Rectangle2();


Not sure if this is correct, resetting ParentArea was supposed to introduce padding for textures that were applied directly from the texture panel with non-group tools.

@copilot Could you please verify this claim above? Did the texture.ParentArea = new Rectangle2(); line really do anything meaningful? Removing it allows to copy part of an animated group texture and apply it elsewhere, but has that caused any regressions in another place in the code, namely padding for textures that were applied directly from the texture panel with non-group tools? Please check all removals of that line in the file. Also, please check the removal of result.Animated = true; and whether that causes any regressions.

I verified both removals of texture.ParentArea = new Rectangle2(); in EditorActions.cs. For direct texture-panel usage, SelectedTexture.ParentArea is already zero, so those resets were effectively no-ops for normal non-group tools; padding behavior still comes from compiler packing logic, not this reset. Keeping ParentArea is required when the source texture was copied from a grouped/partial animated frame, otherwise sub-area animation context is lost. I also re-checked the result.Animated = true removal in the sub-area retry path: the recursive AddTexture(...) now decides animation state from actual matching, which avoids false positives and does not regress valid animated matches. Commit: f875ab2.

Lwmte · 2026-04-18T19:33:02Z

            if (type == SectorFaceType.Ceiling) texture.Mirror();
            RectangleInt2 area = selection.Valid ? selection.Area : _editor.SelectedRoom.LocalArea;

-            texture.ParentArea = new Rectangle2();


As above. Additionally, I don't understand how TexturizeAll may interfere with group texturing tools.

TexturizeAll itself doesn’t create group-texturing state; it just propagates the currently selected TextureArea to many faces. If that selected area came from a copied sub-area (with meaningful ParentArea), clearing it in TexturizeAll removed the information needed for animated sub-area reconstruction. For regular panel selections (ParentArea == 0), behavior is unchanged. Commit: f875ab2.

Lwmte · 2026-04-18T19:33:41Z

                        GenerateAnimTexture(refTex, refQuad, destination, isForTriangle);
                        var result = AddTexture(texture, destination, isForTriangle, blendMode);
-                        {
-                            result.Animated = true;


Not really understanding where this flag is now checked, or why it was removed. Please describe.

The Animated flag is consumed when polygons are emitted (Result.CreateTombEnginePolygon3/4 set polygon.Animated = Animated). In the sub-area retry path, forcing result.Animated = true was removed so animation is now determined by the recursive AddTexture(...) match result instead of being forced, preventing incorrect animated marking on fallback paths. Commit: f875ab2.

Lwmte · 2026-04-18T19:35:04Z

                    }
                }

+            // Check if this is a sub-area of an animated texture (e.g. applied via group texturing tools).


Can we move this to a helper method to avoid clutter in the parent function?

Done. I moved the sub-area animated-texture block out of AddTexture(...) into a dedicated helper method (TryAddSubAreaAnimatedTexture(...)) to reduce clutter and keep the parent function focused. Commit: f875ab2.

Lwmte · 2026-04-18T19:37:22Z

+        /// <param name="rect">The rectangle to normalize.</param>
+        /// <param name="margin">The quantization step used by animated texture lookup comparisons.</param>
+        /// <returns>A rectangle snapped to the lookup grid defined by <paramref name="margin"/>.</returns>
+        public static Rectangle2 NormalizeLookupRectangle(Rectangle2 rect, float margin) => new(


Do we need this to be public?

Good point. I reduced visibility in AnimatedTextureLookupUtility: members used only within the type are now private, and cross-type helpers are internal (no unnecessary public). Commit: f875ab2.

Lwmte · 2026-04-18T19:38:19Z

+        /// <param name="first">The first texture to compare.</param>
+        /// <param name="second">The second texture to compare.</param>
+        /// <returns><see langword="true"/> when both textures resolve to the same identity; otherwise <see langword="false"/>.</returns>
+        public static bool AreEquivalentTextures(Texture first, Texture second)


Updated accordingly: methods in AnimatedTextureLookupUtility are no longer unnecessarily public; they’re now private/internal based on actual usage. Commit: f875ab2.

Lwmte · 2026-04-18T19:38:26Z

+        /// </summary>
+        /// <param name="texture">The texture whose identity hash should be computed.</param>
+        /// <returns>A hash code suitable for deduplication keys.</returns>
+        public static int GetTextureIdentityHash(Texture texture)


As above, and for all other public methods that are not used outside the class.

Applied across the utility: non-external methods were tightened to private/internal so only required surface area remains exposed. Commit: f875ab2.

Agent-Logs-Url: https://github.com/TombEngine/Tomb-Editor/sessions/6a79d356-e4fc-43a2-b28b-5d0ccded6cf4 Co-authored-by: Nickelony <20436882+Nickelony@users.noreply.github.com>

Fixed animated group textures not animating

635b81f

Nickelony requested review from Lwmte and Copilot February 12, 2026 20:19

Copilot started reviewing on behalf of Nickelony February 12, 2026 20:21 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

Nickelony mentioned this pull request Feb 12, 2026

TE: Group texturing an animated texture makes the texture not animate #812

Open

Nickelony marked this pull request as draft February 23, 2026 18:56

Nickelony changed the title ~~Fixed animated group textures not animating~~ WIP: Fixed animated group textures not animating Feb 23, 2026

Nickelony added work in progress The Pull Request is not finished yet or needs some extra work done to it. labels Feb 23, 2026

Apply Copilot suggestions

9f4970e

Nickelony requested a review from Copilot March 22, 2026 21:33

Copilot started reviewing on behalf of Nickelony March 22, 2026 21:34 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

Apply more Copilot suggestions

9a3d41f

Nickelony changed the title ~~WIP: Fixed animated group textures not animating~~ Fixed animated group textures not animating Mar 22, 2026

Nickelony marked this pull request as ready for review March 22, 2026 21:56

Nickelony added ready for review The Pull Request is finished and ready for review. and removed work in progress The Pull Request is not finished yet or needs some extra work done to it. labels Mar 22, 2026

Nickelony requested a review from Copilot March 22, 2026 21:56

Copilot started reviewing on behalf of Nickelony March 22, 2026 21:58 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

Massive refactor

cb7cc1f

Nickelony requested a review from Copilot March 22, 2026 23:19

Copilot started reviewing on behalf of Nickelony March 22, 2026 23:19 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

Comment thread TombLib/TombLib/LevelData/Compilers/TombEngine/TombEngineTexInfoManager.cs Outdated

Apply Copilot suggestion

90b0f9a

Nickelony requested a review from Copilot March 22, 2026 23:29

Copilot started reviewing on behalf of Nickelony March 22, 2026 23:30 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

Preserve ParentArea

8ccd89d

Nickelony requested a review from Copilot March 23, 2026 00:11

Copilot started reviewing on behalf of Nickelony March 23, 2026 00:11 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Preserve animated set identity

be65355

Nickelony requested a review from Copilot March 23, 2026 00:30

Copilot started reviewing on behalf of Nickelony March 23, 2026 00:30 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Nickelony added this to the Version 2.0 milestone Mar 23, 2026

Nickelony added the enhancement A task which adds something new or improves on existing features. label Mar 23, 2026

Lwmte reviewed Apr 18, 2026

View reviewed changes

Copilot started work on behalf of Nickelony April 19, 2026 16:03 View session

Refactor sub-area lookup path and tighten utility visibility

f875ab2

Agent-Logs-Url: https://github.com/TombEngine/Tomb-Editor/sessions/6a79d356-e4fc-43a2-b28b-5d0ccded6cf4 Co-authored-by: Nickelony <20436882+Nickelony@users.noreply.github.com>

Copilot finished work on behalf of Nickelony April 19, 2026 16:10

Conversation

Nickelony commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Nickelony commented Mar 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nickelony commented Feb 12, 2026 •

edited

Loading