fix: 名前検索RPCのローマ字検索をcase-insensitiveに変更#1417
Merged
TinyKitten merged 3 commits intodevfrom Mar 6, 2026
Merged
Conversation
get_stations_by_nameクエリのLIKEをILIKEに変更し、 ローマ字(station_name_rn)等の大文字小文字を区別せずに検索できるようにした。 https://claude.ai/code/session_01B3dLcBJ9hv2Njw6RXD1kwP
日本語・中国語・韓国語カラムにはcase-insensitive比較は不要なため、 ILIKEはローマ字カラム(station_name_rn)のみに適用し、 他のカラムはLIKEに戻した。 https://claude.ai/code/session_01B3dLcBJ9hv2Njw6RXD1kwP
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_stations_by_nameクエリのstation_name_rnカラムの比較をLIKEからILIKEに変更し、ローマ字検索時に大文字小文字を区別しないようにしたLIKEのままTest plan
tokyo)で検索して結果が返ることを確認Tokyo)で検索して同じ結果が返ることを確認https://claude.ai/code/session_01B3dLcBJ9hv2Njw6RXD1kwP
Summary by CodeRabbit
バグ修正