Update to Components V2 to avoid field length limit error#5
Open
hyperneutrino wants to merge 1 commit intomainfrom
Open
Update to Components V2 to avoid field length limit error#5hyperneutrino wants to merge 1 commit intomainfrom
hyperneutrino wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding the Stoat Mods role to the leave switcher, we are exceeding the 1024 length limit for field values. Switching to Components V2 should mitigate this issue for now as we get a 4000 message-wide limit to work with here.
Components V2 is planned to be used across the entire organization in the future, but that's a future consideration.
Also, fixes the switcher saying "both" servers — it applies in TP, EP, and TSO, so that is inaccurate.
Moving the buttons into one row is personal preference, but I think it looks a lot better.