Skip to content

fix: kiuwan issues#51

Merged
MotherJammer merged 21 commits intodevelopfrom
fix/kiuwan-issues
Mar 5, 2026
Merged

fix: kiuwan issues#51
MotherJammer merged 21 commits intodevelopfrom
fix/kiuwan-issues

Conversation

@MotherJammer
Copy link
Copy Markdown

This PR fixes the following issues reported by Kiuwan:

  • Provide Javadoc comments for public classes and interfaces - For classes on exceptions, responses and utils folders + POS Autoservicio + POS Integrado
  • Do not use Runtime and System classes - For Serial.java
  • Cyclomatic complexity - For Serial.java, on write method
  • Do not instantiate temporal Objects in loops bodies - For Serial.java
  • Avoid catch blocks with empty bodies - For Serial.java
  • Avoid using while() and sleep(), instead use wait() and notify() - For Serial.java
  • Maximum allowed number of methods - For Serial.java

Successful report

Captura de pantalla 2026-02-27 a las 16 11 38

@MotherJammer MotherJammer changed the title Fix/kiuwan issues fix: kiuwan issues Feb 27, 2026
Comment thread src/main/java/cl/transbank/pos/utils/Serial.java Outdated
@MotherJammer MotherJammer requested a review from mastudillot March 4, 2026 11:30
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 5, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@MotherJammer MotherJammer merged commit 466892e into develop Mar 5, 2026
3 of 4 checks passed
@MotherJammer MotherJammer deleted the fix/kiuwan-issues branch March 5, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants