slaunch: move TPM relinquish locality call after ExitBootServices#31
Open
accek-itl wants to merge 1 commit intoTrenchBoot:tb-devfrom
Open
slaunch: move TPM relinquish locality call after ExitBootServices#31accek-itl wants to merge 1 commit intoTrenchBoot:tb-devfrom
accek-itl wants to merge 1 commit intoTrenchBoot:tb-devfrom
Conversation
The grub_tpm_relinquish_locality(0) must be called before starting TXT, because Intel SINIT expects no locality active. But relinquishing it in grub_txt_boot_prepare is too early in EFI case - Linux kernel EFI stub did not run yet and it uses TPM for measured boot (non-DRTM, static root of trust). This is fixed here by moving the call to the DL Stub. Signed-off-by: Szymon "accek" Acedański <accek@invisiblethingslab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The grub_tpm_relinquish_locality(0) must be called before starting TXT, because Intel SINIT expects no locality active. But relinquishing it in grub_txt_boot_prepare is too early in EFI case - Linux kernel EFI stub did not run yet and it uses TPM for measured boot (non-DRTM, static root of trust).
This is fixed here by moving the call to the DL Stub.
Tested:
grub-sl-2.12-v15branchFixes PCR 9 update errors shown when booting Linux with
efi=debugand events show up in/sys/kernel/security/tpm0/binary_bios_measurements