Correctly process ES6 inline/side-effect imports#79
Open
arshaw wants to merge 5 commits intoTypeStrong:masterfrom
Open
Correctly process ES6 inline/side-effect imports#79arshaw wants to merge 5 commits intoTypeStrong:masterfrom
arshaw wants to merge 5 commits intoTypeStrong:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My typescript project sometimes outputs lines like these in the generated .d.ts files:
It's essentially an inline ES6 import statement and it's valid code within a typescript definition file. I was having trouble pinpointing the exact conditions necessary to make this happen, but it happens nonetheless.
dts-bundle does not know how to process these and it outputs the line as-is, causing an unresolved module error. This PR fixes it.
Edit
The following type of imports were also not working ("side-effect-only" imports):
I've included a fix for that as well.