Optionally disable exclusion of private members#87
Open
longlostbro wants to merge 2 commits intoTypeStrong:masterfrom
Open
Optionally disable exclusion of private members#87longlostbro wants to merge 2 commits intoTypeStrong:masterfrom
longlostbro wants to merge 2 commits intoTypeStrong:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extending a class that has private members in a mono repo environment vscode will give typescript errors saying the instance of such an object doesn't match the typescript declaration. To fix we need to make sure to include private members in the declaration. This is done by default in typescript but dts-bundle was excluding them without option to include them.