refactor(compat): replace [[ with [ ] for Bash 3.0+#610
Merged
Chemaclass merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
Contributor
✅ Contributor ReportUser: @Chemaclass This user is on the trusted contributors list and was automatically approved. |
f46a3b9 to
0989925
Compare
Replace all [[ ]] test constructs with POSIX-compatible [ ] in src/. Use grep -c instead of grep -q to work around Bash 3.0 set -e pipeline bug. Save real grep path as $GREP to prevent spy interference with framework internals.
00cc4c9 to
e66ee9f
Compare
JesusValeraDev
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[[ ]]test constructs across 28 source files with Bash 3.0+ compatible alternatives[[ ]]→[ ]for simple tests,[ = ]for equality,grep -qE/sedfor regex,casefor glob matching[[ A || B ]]to[ A ] || [ B ]