Workaround build error with clang/libc++ in agi::fs::path#366
Draft
driver1998 wants to merge 1 commit intoTypesettingTools:masterfrom
Draft
Workaround build error with clang/libc++ in agi::fs::path#366driver1998 wants to merge 1 commit intoTypesettingTools:masterfrom
driver1998 wants to merge 1 commit intoTypesettingTools:masterfrom
Conversation
The `std::basic_fstream` implementation in libc++ does not allow constructing with a derived class of `std::filesystem::path` like `agi::fs::path`. (There is a `is_same_v` constraint.) Workaround by getting its underly string manually. Fixes building with LLVM based MinGW environments, including Windows on ARM. This kind of defeat the purpose of `agi::fs::path`, therefore currently sent as draft.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
std::basic_fstreamimplementation in libc++ does not allow constructing with a derived class ofstd::filesystem::pathlikeagi::fs::path. (There is ais_same_vconstraint.)Workaround by getting its underly string manually. Fixes building with LLVM based MinGW environments, including Windows on ARM.
This kind of defeats the purpose of
agi::fs::path, therefore currently sent as draft.