Fix .ass non-integer margin values#444
Open
ALRBP wants to merge 3 commits intoTypesettingTools:masterfrom
Open
Fix .ass non-integer margin values#444ALRBP wants to merge 3 commits intoTypesettingTools:masterfrom
ALRBP wants to merge 3 commits intoTypesettingTools:masterfrom
Conversation
Member
|
While this PR improves parsing in some places, it's not complete. The main two issues are:
If integer parsing is updated, I'd like to make it fully match vsfilter/libass's parsing across all integer values. In fact, I think the best course of action is to just copy-paste the relevant libass code with a comment explaining the motivation and giving the proper copyright notices. (In theory it's also possible to call libass directly to do the parsing, but that would need a fair bit of hacking to handle cases like comments, invalid styles, etc.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #443
"bad lexical cast" when parsing .ass file.
When the parser fails to parse an integer, it will now try to parse and round a float, if this also fails (eg. empty value) it defaults to 0.