Skip to content

Fix invalid formula error in round_to_seq example and bump version to 1.24.1 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
+11 −5
Open

Fix invalid formula error in round_to_seq example and bump version to 1.24.1 #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca275fc
Initial plan
Copilot Mar 3, 2026
f00fa12
Fix round_to_seq example: change plot(w,x) to plot(w)
Copilot Mar 3, 2026
8b115f4
Bump version to 1.24.1, update NEWS.md and README.md
Copilot Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: netdiffuseR
Title: Analysis of Diffusion and Contagion Processes on Networks
Version: 1.24.0
Version: 1.24.1
Authors@R: c(
person("George", "Vega Yon", email="g.vegayon@gmail.com", role=c("aut", "cre"),
comment=c(ORCID = "0000-0002-3171-0844", what="Rewrite functions with Rcpp, plus new features")
Expand Down
6 changes: 6 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# Changes in netdiffuseR version 1.24.1 (2026-03-03)

* Fixed CRAN example error in `round_to_seq()`: `plot(w, x)` replaced with
`plot(w)` to avoid `%||%` operator issue in R 4.4.0+'s `formula.default`
when called via `plot.data.frame()`.

# Changes in netdiffuseR version 1.24.0 (2025-12-09)

* New function `degree_adoption_diagnostic()` analyzes the correlation between network
Expand Down
2 changes: 1 addition & 1 deletion R/plot_diffnet2.r
View file
Open in desktop
Copy link
Member

@aoliveram aoliveram Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the example using

> packageVersion("netdiffuseR")
[1] ‘1.24.0’

and effectively the plots are equal, except for the xlab:

library(netdiffuseR)

x <- rnorm(100)
w <- data.frame(as.integer(round_to_seq(x, as_factor = TRUE)),x)
plot(w,x) # --> weird xlab (numerical)
plot(w)   # --> also weird xlab (non-numerical)

Copy link
Member

@gvegayon gvegayon Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks for checking. I just asked copilot to make a few changes before we resubmit to CRAN.

Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#'
#' x <- rnorm(100)
#' w <- data.frame(as.integer(round_to_seq(x, as_factor = TRUE)),x)
#' plot(w,x)
#' plot(w)
#'
#' @seealso Used in \code{\link{diffmap}} and \code{\link{plot_diffnet2}}
round_to_seq <- function(x, nlevels=20, as_factor=FALSE) {
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ And the actual R package:
Vega Yon G, Olivera Morales A, Valente T (2025). _netdiffuseR:
Analysis of Diffusion and Contagion Processes on Networks_.
doi:10.5281/zenodo.1039317 <https://doi.org/10.5281/zenodo.1039317>,
R package version 1.24.0, <https://github.com/USCCANA/netdiffuseR>.
R package version 1.24.1, <https://github.com/USCCANA/netdiffuseR>.

To see these entries in BibTeX format, use 'print(<citation>,
bibtex=TRUE)', 'toBibtex(.)', or set
Expand Down Expand Up @@ -374,7 +374,7 @@ sessionInfo()
#> [1] stats graphics grDevices utils datasets methods base
#>
#> other attached packages:
#> [1] netdiffuseR_1.24.0
#> [1] netdiffuseR_1.24.1
#>
#> loaded via a namespace (and not attached):
#> [1] Matrix_1.7-4 jsonlite_2.0.0 dplyr_1.1.4
Expand Down
2 changes: 1 addition & 1 deletion man/round_to_seq.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading