Skip to content

feat: Implement discount programs uploader #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
NewdlDewdl wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: Implement discount programs uploader #128

NewdlDewdl wants to merge 2 commits into from
+119 −5

Conversation

@NewdlDewdl
Copy link
Contributor

@NewdlDewdl NewdlDewdl commented Feb 10, 2026 •
edited
Loading

Overview

Implements the uploader for discount programs as requested in #122.

Changes

  • Created uploader/discountsUploader.go following existing uploader patterns
  • Updated main.go to handle -upload -discounts flag
  • Updated README.md with upload documentation
  • Enabled the discount pipeline in runners/weekly.sh
  • Added unit tests for the discounts uploader

Implementation Details

  • Uses UploadData[schema.DiscountProgram]
  • Collection name: discounts (matches discounts.json filename convention)
  • Handles file-not-found gracefully
  • Replaces existing data (consistent with other standalone uploaders)

Testing

  • Code builds successfully

Closes #122

@rohin-sudo
feat: implement discount programs uploader (UTDNebula#122)
15b34ce 
- Add discountsUploader.go following existing uploader patterns
- Update main.go to handle -upload -discounts flag
- Update README.md with upload documentation
- Enable discount upload in weekly runner script
- Collection name: discounts (matches discounts.json filename)

Resolves UTDNebula#122
@rohin-sudo
test(uploader): add unit tests for discounts uploader
bb2df3c
@NewdlDewdl NewdlDewdl mentioned this pull request Feb 10, 2026
Open
@NewdlDewdl
Copy link
Contributor Author

NewdlDewdl commented Feb 10, 2026

@mikehquan19 implemented the discounts uploader for #122.

Summary:

  • Added uploader/discountsUploader.go (supports -upload -discounts)
  • Updated docs and weekly runner
  • Added unit tests for the discounts uploader

Would appreciate a quick review when you have time.

@mikehquan19
Copy link
Contributor

mikehquan19 commented Feb 10, 2026

Will do, thanks.

@NewdlDewdl
Copy link
Contributor Author

NewdlDewdl commented Feb 10, 2026

@mikehquan19 follow-up: re-reviewed #122 and confirmed this PR matches the request (uploader implementation + docs + runner).

Local MongoDB integration sanity check:

  • Started a temporary mongo:7 container
  • Set MONGODB_URI=mongodb://localhost:27018
  • Ran: ./api-tools -upload -discounts -i ./tmp/discounts_upload_test
  • Verified combinedDB.discounts.countDocuments() == 2

So the uploader path works end-to-end against MongoDB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement the uploader for discount programs

3 participants

@NewdlDewdl @mikehquan19 @rohin-sudo