fix(apollo-vertex): add expanded row in data table#388
Open
alincadariu wants to merge 1 commit intomainfrom
Open
fix(apollo-vertex): add expanded row in data table#388alincadariu wants to merge 1 commit intomainfrom
alincadariu wants to merge 1 commit intomainfrom
Conversation
alincadariu
requested review from
0xr3ngar,
angeloaltamiranom,
frankkluijtmans and
ruudandriessen
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
alincadariu
force-pushed
the
alincadariu/datatable-row-expanded
branch
from
934cab0 to
09bd6e1
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alincadariu
force-pushed
the
alincadariu/datatable-row-expanded
branch
from
09bd6e1 to
fab8c6d
Compare
KokoMilev
requested changes
Mar 24, 2026
| expanded={expanded} | ||
| onExpandedChange={setExpanded} | ||
| renderExpandedRow={(row) => { | ||
| const payment = row.original as Payment; |
| renderExpandedRow={(row) => { | ||
| const payment = row.original as Payment; | ||
| return ( | ||
| <div className="grid grid-cols-4 gap-4 p-4 text-sm"> |
Contributor
There was a problem hiding this comment.
Maybe we can add some left margin/padding to the expanded row since it doesn't look pretty at the moment.
In my opinion this looks better:
| expanded={expanded} | ||
| onExpandedChange={setExpanded} | ||
| renderExpandedRow={(row) => { | ||
| const payment = row.original as Payment; |
Contributor
There was a problem hiding this comment.
This cast is not needed.
| return ( | ||
| <div className="grid grid-cols-4 gap-4 p-4 text-sm"> | ||
| <div> | ||
| <span className="text-muted-foreground">ID</span> |
Contributor
There was a problem hiding this comment.
Maybe we can add more data props (like date, method, etc..) which to be shown in the expanded row, since the information looks very repeatable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i realized we broke the expanded row example with the data table hooks refactors.
Summary
expandedstate,onExpandedChange, andrenderExpandedRowdata-table.tsxby usingReact.Fragmentwith keyTest plan
payments-demokeys🤖 Generated with Claude Code