feat(apollo-vertex): add Combobox component with multi-select#392
Open
alincadariu wants to merge 1 commit intomainfrom
Open
feat(apollo-vertex): add Combobox component with multi-select#392alincadariu wants to merge 1 commit intomainfrom
alincadariu wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
alincadariu
force-pushed
the
alincadariu/add-vertex-combobox
branch
6 times, most recently
from
a7a1056 to
f1f6d6a
Compare
Adds a new Combobox registry component built on Popover + Command (cmdk), supporting single and multi-select with badge chips. Includes documentation page with live examples and dynamic templates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alincadariu
force-pushed
the
alincadariu/add-vertex-combobox
branch
from
f1f6d6a to
6e2664c
Compare
alincadariu
requested review from
0xr3ngar,
angeloaltamiranom,
frankkluijtmans and
ruudandriessen
as code owners
| className="w-[360px] h-auto min-h-9" | ||
| placeholder="Select frameworks..." | ||
| > | ||
| {values.length > 0 ? ( |
There was a problem hiding this comment.
🤔 How does this handle large selection e.g. around 10 values are selected, How the selection will be displayed,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
combobox.mov
Summary
Comboboxregistry component to apollo-vertex, built on existingPopover+Command(cmdk) primitives — no new npm dependenciesonValueChangereturnsstringfor single,string[]for multi/shadcn-components/combobox) with live interactive examplesComboboxSingleSelectTemplate,ComboboxMultiSelectTemplate) following theDataTableTemplatepatternregistry.jsonwith dependencies onbadge,button,command,popoverTest plan
pnpm --filter apollo-vertex build— should passpnpm --filter apollo-vertex devand navigate to/shadcn-components/comboboxnpx shadcn@latest add @uipath/comboboxinstalls correctly from registry🤖 Generated with Claude Code