Skip to content

Add CI check for min required version#1480

Draft
minion-workers[bot] wants to merge 1 commit intomainfrom
minion/issue-1458
Draft

Add CI check for min required version#1480
minion-workers[bot] wants to merge 1 commit intomainfrom
minion/issue-1458

Conversation

@minion-workers
Copy link

Summary

Resolves #1458

Done. Here's a summary of what was created:

New files

  1. .github/scripts/check_min_required_version.py — CI check script that:

    • Detects which packages were changed in the PR (via git diff)
    • For each changed package, checks if any of its in-repo dependencies were also changed
    • If both a package and its dependency are changed, verifies the minimum required version (>=X.Y.Z) matches the dependency's current version
    • Exits with code 1 and clear error messages when violations are found
  2. .github/scripts/test_check_min_required_version.py — 12 tests covering:

    • parse_min_version: extracting min versions from dependency specifiers
    • check_min_versions: matching/outdated versions, skipping unchanged deps, multiple violations
    • main: no changes, passing, and failing scenarios

How it works

When a PR modifies both uipath-core (at version 0.5.7) and uipath-platform (which depends on uipath-core>=0.5.4), the script fails because 0.5.4 != 0.5.7, prompting the developer to update the minimum version to >=0.5.7.

The script follows the same patterns as the existing check_version_uniqueness.py (env vars, git diff, tomllib parsing).

Changes

 .github/scripts/check_min_required_version.py      | 166 ++++++++++++++++++
 .github/scripts/test_check_min_required_version.py | 192 +++++++++++++++++++++
 2 files changed, 358 insertions(+)
Files changed
.github/scripts/check_min_required_version.py
.github/scripts/test_check_min_required_version.py

Created by Minion Worker — autonomous Claude Code agent
To request changes, comment mentioning @minion.

  Resolves #1458

  Co-Authored-By: Claude <noreply@anthropic.com>
@minion-workers
Copy link
Author

Minion Review Gate: Starting review (round 1). Watch live

@minion-workers
Copy link
Author

Minion Review Gate: Changes requested. The implementer agent will address the issues above.

@minion-workers
Copy link
Author

Minion Feedback Agent completed

Metric Value
Model unknown
Turns 14
Cost $unknown
Workflow Run Run 71
Agent Summary

All checks are passing and there's no specific feedback to address — the review feedback fields are all empty. The PR is in good shape:

  • 12/12 tests pass
  • Lint clean (ruff check)
  • Format clean (ruff format)

No changes needed.

@minion-workers
Copy link
Author

Minion Worker reviewed the feedback but determined no code changes were needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI check for min required version

1 participant