feat: add fallback for folder_key in mcp service#1484
Open
dianagrecu-uipath wants to merge 2 commits intomainfrom
Open
feat: add fallback for folder_key in mcp service#1484dianagrecu-uipath wants to merge 2 commits intomainfrom
dianagrecu-uipath wants to merge 2 commits intomainfrom
Conversation
github-actions
bot
added
the
test:uipath-langchain
dianagrecu-uipath
force-pushed
the
feat/add-fallback-for-folder_key-mcp
branch
from
d06a551 to
a897686
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
UIPATH_FOLDER_KEY is properly populated by the container runtime, but UIPATH_FOLDER_PATH is not. This becomes an issue for services like MCP, where @resource_override handles folder_path — but when there's no resource override, the code falls through to retrieve_folder_key(folder_path), which throws a ValueError because folder_path is None.
Added a fallback for folder_key - in case folder_path is missing, then take folder_key value from FolderContext (since mcp service already inherited FolderContext).