-
Notifications
You must be signed in to change notification settings - Fork 1
fix: low code conversational agents to emit start tool call on approval #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the right place to do this .. tool call confirmation is just one of multiple interruptable use-cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do you recommend this go? I have detailed justification on why I couldn't get langchain repo to work in the PR description, but runtime is (from my understanding) only place that can emit start tool call between
AImessage.toolCallandtoolMessage. We don't want socket logic intool_node.pyeitherUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoshParkSJ
If I'm reading this correctly, the current order of operations is
AIMessage => startToolCall => startInterrupt(which is the expected, correct sequence), and what you're trying to achieve isAIMessage => startInterrupt => startToolCall.If that's right, I'd push back on solving this in the runtime. The confusing UX you're describing, users seeing both tool call UI and interrupt UI simultaneously, is a client-side state machine problem. The client should be able to handle receiving
startToolCallbeforestartInterruptwithout rendering both at the same time. Reordering backend events to paper over a client rendering issue is the wrong layer to fix this, and it pulls protocol sequencing logic into the runtime in a way that'll be hard to unpick later.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be worth exploring how these guys https://github.com/ag-ui-protocol/ag-ui handle the same scenario
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point - I'll move this handling to CAS. Appreciate the feedback!