Fix double-counted margins for shared spanning labels at space=0#584
Merged
cvanelteren merged 1 commit intomainfrom Feb 13, 2026
Merged
Fix double-counted margins for shared spanning labels at space=0#584cvanelteren merged 1 commit intomainfrom
cvanelteren merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix addresses a layout regression where figures with
space=0and shared/spanning axis labels (xlabel/ylabel) reserved too much margin on the left and bottom edges. The root cause was that spanning figure-level labels were being included in tight-layout calculations while placeholder axis labels were also used to reserve space, effectively counting label extents twice. The patch marks spanning labels as out-of-layout (in_layout=False) so tight layout only accounts for the intended placeholder label extents. A regression test was added to verify spanning labels are excluded from layout accounting and that margins remain compact forspace=0cases.