Skip to content

[pull] master from DefinitelyTyped:master #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Jan 31, 2026
Merged

[pull] master from DefinitelyTyped:master #1597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e138fcf
🤖 Merge PR #74435 [openseadragon] update package.json contributors by…
saini11shubh Jan 31, 2026
a6d6651
🤖 Merge PR #74434 [openseadragon] Fix: Element type by @rssaini01
rssaini01 Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 33 additions & 33 deletions types/openseadragon/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ declare namespace OpenSeadragon {

function getCssPropertyWithVendorPrefix(property: string): string;

function getElement(element: string | Element): Element;
function getElement(element: string | Element): HTMLElement;

function getElementOffset(element: Element | string): Point;

Expand Down Expand Up @@ -146,11 +146,11 @@ declare namespace OpenSeadragon {
withCredentials?: boolean | undefined;
}): XMLHttpRequest;

function makeCenteredNode(element: Element | string): Element;
function makeCenteredNode(element: Element | string): HTMLElement;

function makeNeutralElement(tagName: string): Element;
function makeNeutralElement(tagName: string): HTMLElement;

function makeTransparentImage(src: string): Element;
function makeTransparentImage(src: string): HTMLElement;

function normalizeEventListenerOptions(
options: boolean | { capture?: boolean; passive?: boolean; once?: boolean },
Expand Down Expand Up @@ -347,7 +347,7 @@ declare namespace OpenSeadragon {
zoomPerDblClickDrag?: number;
zoomPerSecond?: number | undefined;
showNavigator?: boolean | undefined;
navigatorElement?: Element;
navigatorElement?: HTMLElement;
navigatorId?: string | undefined;
navigatorPosition?: "TOP_LEFT" | "TOP_RIGHT" | "BOTTOM_LEFT" | "BOTTOM_RIGHT" | "ABSOLUTE" | undefined;
navigatorSizeRatio?: number | undefined;
Expand Down Expand Up @@ -385,7 +385,7 @@ declare namespace OpenSeadragon {
showSequenceControl?: boolean | undefined;
sequenceControlAnchor?: ControlAnchor | undefined;
navPrevNextWrap?: boolean | undefined;
toolbar?: string | Element | undefined;
toolbar?: string | HTMLElement | undefined;
zoomInButton?: string | Element | undefined;
zoomOutButton?: string | Element | undefined;
homeButton?: string | Element | undefined;
Expand Down Expand Up @@ -442,7 +442,7 @@ declare namespace OpenSeadragon {

class Button extends EventSource<ButtonEventMap> {
currentState: ButtonState;
element: Element;
element: HTMLElement;
fadeDelay: number;
fadeLength: number;
tracker: MouseTracker;
Expand Down Expand Up @@ -474,7 +474,7 @@ declare namespace OpenSeadragon {

class ButtonGroup {
buttons: Button[];
element: Element;
element: HTMLElement;
tracker: MouseTracker;

constructor(options: { buttons: Button[]; element?: Element | undefined });
Expand All @@ -492,9 +492,9 @@ declare namespace OpenSeadragon {
class Control {
anchor: ControlAnchor;
autoFade: boolean;
container: Element;
element: Element;
wrapper: Element;
container: HTMLElement;
element: HTMLElement;
wrapper: HTMLElement;

constructor(element: Element, options: TControlOptions, container: Element);

Expand Down Expand Up @@ -522,15 +522,15 @@ declare namespace OpenSeadragon {
}

class Drawer {
canvas: HTMLCanvasElement | HTMLElement;
container: Element;
canvas: HTMLCanvasElement;
container: HTMLElement;
context: CanvasRenderingContext2D | null;
// element : Element; // Deprecated

constructor(options: {
viewer: Viewer;
viewport: Viewport;
element: Element;
element: HTMLElement;
debugGridColor?: string | undefined;
});

Expand Down Expand Up @@ -575,13 +575,13 @@ declare namespace OpenSeadragon {
interface TDrawerOptions {
viewer: Viewer;
viewport: Viewport;
element: Element;
element: HTMLElement;
debugGridColor?: number;
}

class CanvasDrawer extends DrawerBase {
canvas: Element;
container: Element;
canvas: HTMLCanvasElement;
container: HTMLElement;

constructor(options: TDrawerOptions);
}
Expand Down Expand Up @@ -624,8 +624,8 @@ declare namespace OpenSeadragon {
}

class HTMLDrawer extends DrawerBase {
canvas: Element;
container: Element;
canvas: HTMLCanvasElement;
container: HTMLElement;
constructor(options: TDrawerOptions);
}

Expand Down Expand Up @@ -702,7 +702,7 @@ declare namespace OpenSeadragon {
}

interface MouseTrackerOptions {
element: Element | string;
element: HTMLElement | string;
startDisabled?: boolean | undefined;
clickTimeThreshold?: number | undefined;
clickDistThreshold?: number | undefined;
Expand Down Expand Up @@ -743,7 +743,7 @@ declare namespace OpenSeadragon {
clickDistThreshold: number;
dblClickTimeThreshold: number;
dblClickDistThreshold: number;
element: Element;
element: HTMLElement;

constructor(options: MouseTrackerOptions);

Expand Down Expand Up @@ -787,7 +787,7 @@ declare namespace OpenSeadragon {
interface EventProcessInfo {
eventSource: MouseTracker;
originalEvent: Event;
originalTarget: Element;
originalTarget: HTMLElement;
eventPhase: EventPhase;
eventType:
| "keydown"
Expand Down Expand Up @@ -874,7 +874,7 @@ declare namespace OpenSeadragon {
type OnDrawCallback = (position: Point, size: Point, element: Element) => void;

interface OverlayOptions {
element: Element;
element: HTMLElement;
location: Point | Rect;
placement?: Placement | undefined;
onDraw?: OnDrawCallback | undefined;
Expand Down Expand Up @@ -975,7 +975,7 @@ declare namespace OpenSeadragon {
bounds: Rect;
cacheKey: string;
context2D: CanvasRenderingContext2D;
element: Element;
element: HTMLElement;
exists: boolean;
flipped: boolean;
hasTransparency: boolean;
Expand Down Expand Up @@ -1229,10 +1229,10 @@ declare namespace OpenSeadragon {
}

class Viewer {
canvas: Element;
container: Element;
canvas: HTMLCanvasElement;
container: HTMLElement;
drawer: Drawer;
element: Element;
element: HTMLElement;
initialPage: number;
navigator: Navigator;
viewport: Viewport;
Expand Down Expand Up @@ -1384,8 +1384,8 @@ declare namespace OpenSeadragon {
}

class WebGLDrawer extends DrawerBase {
canvas: Element;
container: Element;
canvas: HTMLCanvasElement;
container: HTMLElement;

constructor(options: TDrawerOptions);

Expand Down Expand Up @@ -1573,7 +1573,7 @@ declare namespace OpenSeadragon {
}

interface AddOverlayEvent extends ViewerEvent {
element: Element;
element: HTMLElement;
location: Point | Rect;
placement: Placement;
}
Expand All @@ -1598,7 +1598,7 @@ declare namespace OpenSeadragon {
interface CanvasClickEvent extends CanvasEvent {
quick: boolean;
shift: boolean;
originalTarget: Element;
originalTarget: HTMLElement;
preventDefaultAction: boolean;
}

Expand Down Expand Up @@ -1780,7 +1780,7 @@ declare namespace OpenSeadragon {
}

interface RemoveOverlayEvent extends ViewerEvent {
element: Element;
element: HTMLElement;
}

interface ResetSizeEvent extends ViewerEvent {
Expand Down Expand Up @@ -1841,7 +1841,7 @@ declare namespace OpenSeadragon {
}

interface UpdateOverlayEvent extends ViewerEvent {
element: Element;
element: HTMLElement;
location: Point | Rect;
placement: Placement;
}
Expand Down
4 changes: 2 additions & 2 deletions types/openseadragon/openseadragon-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ viewer = OpenSeadragon({
});

declare const buttonElement: Element;
declare const toolbarElement: Element;
declare const toolbarElement: HTMLElement;
viewer = OpenSeadragon({
toolbar: "toolbar-id",
zoomInButton: "zoomInButton-id",
Expand Down Expand Up @@ -157,7 +157,7 @@ viewer.addControl(button.element, {

const viewport = new Viewport({ margins: {} });

const element = new Element();
const element = new HTMLElement();

const drawer = new Drawer({ viewer, viewport, element });

Expand Down
4 changes: 4 additions & 0 deletions types/openseadragon/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@
{
"name": "Peter Blazejewicz",
"githubUsername": "peterblazejewicz"
},
{
"name": "Ravi Shankar Saini",
"githubUsername": "rssaini01"
}
]
}