Skip to content

FIX: Update navigation state on move action swap #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MorganHoarau wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

FIX: Update navigation state on move action swap #2388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Packages/com.unity.inputsystem/InputSystem/Plugins/UI/InputSystemUIInputModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1347,7 +1347,15 @@ public InputActionReference rightClick
public InputActionReference move
{
get => m_MoveAction;
set => SwapAction(ref m_MoveAction, value, m_ActionsHooked, m_OnMoveDelegate);
set
{
SwapAction(ref m_MoveAction, value, m_ActionsHooked, m_OnMoveDelegate);
// Because moveAction is the only action cached in the navigation state,
// we need to read new action's current value to avoid stale state from the previous action.
m_NavigationState.move = m_MoveAction?.action != null && m_MoveAction.action.enabled
? m_MoveAction.action.ReadValue<Vector2>()
: Vector2.zero;
}
}

/// <summary>
Expand Down
Loading