fix: networkmanager cannot be started within OnClientStopped or OnServerStopped callbacks#3908
Merged
NoelStephensUnity merged 7 commits intodevelop-2.0.0from Mar 20, 2026
Conversation
michalChrobot
approved these changes
Mar 19, 2026
Adding additional information about some events we have added but do not cover in NetworkManager. Added additional information about starting NetworkManager within OnClientStopped or OnServerStopped. Adding changelog entry.
jabbacakes
approved these changes
Mar 20, 2026
Contributor
jabbacakes
left a comment
jabbacakes
left a comment
There was a problem hiding this comment.
Mostly just wording tweaks. Main change is moving the info about pre-shutdown notifications to the bottom of its section. It makes more sense to me to introduce the 'you will definitely want to do this' info first, and then add the if statement of 'and you can also do this if you need something else'.
com.unity.netcode.gameobjects/Documentation~/components/core/networkmanager.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/components/core/networkmanager.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/components/core/networkmanager.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/components/core/networkmanager.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/components/core/networkmanager.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/components/core/networkmanager.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Amy Reeve <amy.reeve@unity3d.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Based on a user submitted issue, adding the ability to start NetworkManager from within NetworkManager.OnClientStopped or NetworkManager.OnServerStopped.
If a host starts itself within the NetworkManager.OnClientStopped, then it will skip invoking the NetworkManager.OnServerStopped since it will have already been started again.
fixes: #2703
Jira ticket
MTT-10150
Changelog
NetworkManagerfrom within one of its stopped callbacks at the end of shutdown it will fail to start properly.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
No backport. This will be v2.x specific.