feat(PopoutWrapper): add prop scrollLock#9513
Closed
EldarMuhamethanov wants to merge 1 commit intomasterfrom
Closed
feat(PopoutWrapper): add prop scrollLock#9513EldarMuhamethanov wants to merge 1 commit intomasterfrom
EldarMuhamethanov wants to merge 1 commit intomasterfrom
Conversation
Contributor
size-limit report 📦
|
Contributor
e2e tests
|
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9513/7ec8ba54eaa0d6e72a0747a3f9851789dce3a8ff/pkg/@vkontakte/vkui/_pkg.tgzCommit 7ec8ba5 |
Contributor
EldarMuhamethanov
force-pushed
the
e.muhamethanov/popout-wrapper-add-scroll-lock
branch
from
7dedde9 to
7ec8ba5
Compare
EldarMuhamethanov
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9513 +/- ##
==========================================
- Coverage 94.77% 94.77% -0.01%
==========================================
Files 441 441
Lines 11958 11957 -1
Branches 4407 4408 +1
==========================================
- Hits 11333 11332 -1
Misses 625 625
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SevereCloud
reviewed
Feb 26, 2026
| children, | ||
| onClick, | ||
| zIndex = 'var(--vkui--z_index_popout)', | ||
| scrollLock = false, |
Contributor
There was a problem hiding this comment.
nit: Возможно лучше сразу определиться с будущим поведением. Если в будущем по умолчанию блокируем скролл, то нужно сразу делать обратное свойство disableScrollLock
Suggested change
| scrollLock = false, | |
| disableScrollLock = true, |
Contributor
There was a problem hiding this comment.
suggestion: Нужно поправить пример в хуке useScrollLock, там используется PopoutWrapper
vkcom-publisher
added
pr-needs-work
vkcom-publisher
added
pr-needs-work
Contributor
Author
|
Обсудили с командой и решили, что |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Блокировка скролла страницы при показе всплывающих окон перенесена в компонент PopoutWrapper: добавлено свойство
scrollLock. Компоненты, которые рендерят контент через PopoutWrapper (ActionSheet, Alert, ScreenSpinner), больше не вызываютuseScrollLockсами — блокировка включается через пропscrollLockу PopoutWrapper.В результате:
scrollLockв PopoutWrapper вместо отдельного вызоваuseScrollLock;scrollLock.Release notes
Улучшения
scrollLockдля блокировки скролла страницы при показе всплывающего окна.