Add --waves argument to generate waveforms for GHDL and NVC#1101
Open
oscargus wants to merge 1 commit intoVUnit:masterfrom
Open
Add --waves argument to generate waveforms for GHDL and NVC#1101oscargus wants to merge 1 commit intoVUnit:masterfrom
oscargus wants to merge 1 commit intoVUnit:masterfrom
Conversation
This was referenced Mar 5, 2025
Contributor
|
I see that this PR has been open for quite a while. I just want to chip in and say that I think this is a great addition, and it would be very useful to me if merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1099
Closes #1042
The approach here is to pass
--wavesif a waveform file should be generated. That is clearer than the "passing--gtkwave-fmt"-approach earlier used.There is a deprecation warning when passing only
--viewer-fmt/--gtkwave-fmtfor GHDL, but it still generates the file.I also added a new alias
--waves-fmtfor consistency.(I guess that one can also support other simulators generating waveform files. At least for ModelSim/Questa it is possible to generate VCD-files with a few .do-file commands and I guess the same holds for many other simulators.)