Remove redundant directory from Riviera-PRO dataset path#995
Open
por3bski wants to merge 1 commit intoVUnit:masterfrom
Open
Remove redundant directory from Riviera-PRO dataset path#995por3bski wants to merge 1 commit intoVUnit:masterfrom
por3bski wants to merge 1 commit intoVUnit:masterfrom
Conversation
Member
|
Can someone with access to Riviera-PRO test this change/enhancement? |
Author
|
I have access to Riviera-PRO and tested my changes. Acceptance tests, unit tests and vcomponents tests - all passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-datasetargument for Riviera-PRO vsim command points to directory, not file:-dataset <DIR>Filename dataset.asdb is hardcoded and cannot be changed.
Current usage (
-dataset output_path/dataset.asdb) results in creating redundant directory:output_path/dataset.asdb/dataset.asdb