proton: Disable DXVK d3d8 when wined3d is active#9659
Open
wouter-intveld wants to merge 1 commit intoValveSoftware:proton_10.0from
Open
proton: Disable DXVK d3d8 when wined3d is active#9659wouter-intveld wants to merge 1 commit intoValveSoftware:proton_10.0from
wouter-intveld wants to merge 1 commit intoValveSoftware:proton_10.0from
Conversation
PROTON_USE_WINED3D already disables DXVK for d3d11, d3d10, d3d9, and dxgi but not for d3d8. Since DXVK d3d8 depends on the d3d9 backend, leaving it enabled under wined3d causes crashes. Add the same 'not use_wined3d' guard that use_dxvk_dxgi already has. Fixes ValveSoftware#9453
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PROTON_USE_WINED3Dis set, DXVK's d3d8 backend is now also disabled — matching the existing behavior for d3d11, d3d10, d3d9, and dxgi.Changes
proton: Addnot use_wined3dguard touse_dxvk_d3d8, matching the existinguse_dxvk_dxgipattern.README.md: UpdatePROTON_USE_WINED3Ddescription to include d3d8.Fixes ValveSoftware/Proton#9453