fix: don't hide published score sets from search when superseded by unpublished versions#667
Merged
bencap merged 2 commits intorelease-2026.1.1from Feb 26, 2026
Conversation
…npublished versions The superseding score set filter used a LEFT OUTER JOIN that excluded any score set with a superseding version, regardless of publication status. This caused published score sets (e.g. urn:mavedb:00000049) to disappear from search results when an unpublished draft replacement existed. Allow superseded score sets through when the superseding version has no published_date. Also enforce published=True on the filter-options endpoint for consistency with the main search endpoint.
bencap
force-pushed
the
bugfix/bencap/656/search-not-returning-results-for-score-sets-with-unpublished-superseder
branch
from
a12cd00 to
00a2bc7
Compare
jstone-dev
approved these changes
Feb 24, 2026
Base automatically changed from
chore/bencap/agent-md-improvements
to
release-2026.1.1
February 25, 2026 23:14
…urning-results-for-score-sets-with-unpublished-superseder
bencap
deleted the
bugfix/bencap/656/search-not-returning-results-for-score-sets-with-unpublished-superseder
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The superseding score set filter used a LEFT OUTER JOIN that excluded any score set with a superseding version, regardless of publication status. This caused published score sets (e.g. urn:mavedb:00000049) to disappear from search results when an unpublished draft replacement existed.
Allow superseded score sets through when the superseding version has no published_date. Also enforce published=True on the filter-options endpoint for consistency with the main search endpoint.